Bug 1436746 - unify: "Add Selected to SSM" button on System List page, but not on System Overview
Summary: unify: "Add Selected to SSM" button on System List page, but not on System Ov...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite 5
Classification: Red Hat
Component: WebUI
Version: 580
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Gennadii Altukhov
QA Contact: Pavel Studeník
URL:
Whiteboard:
Depends On:
Blocks: sat580-low
TreeView+ depends on / blocked
 
Reported: 2017-03-28 14:30 UTC by Jan Hutař
Modified: 2017-06-21 12:15 UTC (History)
3 users (show)

Fixed In Version: spacewalk-java-2.5.14-77-sat
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-06-21 12:15:21 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
No button in 5.8.0 (108.89 KB, image/png)
2017-03-28 14:30 UTC, Jan Hutař
no flags Details

Description Jan Hutař 2017-03-28 14:30:40 UTC
Created attachment 1266994 [details]
No button in 5.8.0

Description of problem:
Button "Add Selected to SSM" is missing on System Overview page


Version-Release number of selected component (if applicable):
button present: spacewalk-java-2.3.8-158.el6sat.noarch
button missing: spacewalk-java-2.5.14-65.el6sat.noarch


How reproducible:
1 of 1


Steps to Reproduce:
1. Register few systems and to to main menu -> Systems page


Actual results:
Notice that below systems listing button "Add Selected to SSM" is missing. I'll add screenshot


Expected results:
There is a button

Comment 1 Tomas Lestach 2017-03-29 11:08:20 UTC
JanH,
I think is not needed.
By selecting system checkboxes appropriate systems get added to SSM immediately (in case you have javascript enabled).
In case you have javascript disabled, you need to select the system checkboxes and hit the 'Update List' button, that does the addition for you.

Let me know, what else you'd like to achieve.

Comment 2 Jan Hutař 2017-03-29 12:58:20 UTC
As noted by Gennadii, although the button is missing on /rhn/systems/Overview.do, it is present on /rhn/systems/SystemList.do or /rhn/systems/VirtualList.do.

But yes, I do not see this a problem, you are right.

Comment 3 Tomas Lestach 2017-03-31 09:42:20 UTC
Ah, thanks for pointing out the inconsistency. Let's unify it. Re-opening.

I personally do not see the benefit of the "Remove existing servers from the SSM"  checkbox, as the checked items are those in (or to be added to) SSM. I also think the "Update List" button (for js disabled) does, whats expected more intuitively.
But I may miss something.

The goal of this BZ is to unify the approach one way or the other.

Comment 4 Gennadii Altukhov 2017-04-04 15:51:26 UTC
fixed in upstream. spacewalk.git:
bf3aba0c851880eda8d4983134fe63c458ac76ba

Comment 8 Gennadii Altukhov 2017-05-04 09:41:08 UTC
Since WebUI requires JavaScript, it is not necessary to have "Add selected to SSM" button. Remove them in upstream. spacewalk.git:
76f61d3ef915861312a2330bc521ab8824c919a7

Comment 12 Pavel Studeník 2017-05-09 12:51:16 UTC
Verified with spacewalk-java-2.5.14-79.el6sat.noarch

Adding to SSM work by click (using javacript) works and button "Add Selected to SSM" was removed from all pages from "Systems".


Note You need to log in before you can comment on or make changes to this bug.