Bug 1436807 - python-doit: python3-doit is missing Python 3 version of executables
Summary: python-doit: python3-doit is missing Python 3 version of executables
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-doit
Version: 27
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1479730
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-28 17:41 UTC by Iryna Shcherbina
Modified: 2018-08-27 19:26 UTC (History)
6 users (show)

Fixed In Version: python-doit-0.30.3-1.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-10-12 13:35:39 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Latest Python3 upstream version (5.93 KB, patch)
2017-08-04 12:10 UTC, Jan Beran
no flags Details | Diff

Description Iryna Shcherbina 2017-03-28 17:41:02 UTC
The Python 3 subpackage python3-doit is missing executables available in the Python 2 subpackage.

According to the Fedora Packaging guidelines for Python [0], if a Python package that supports Python 3 installs executables into /usr/bin,  then either both Python versions of the executables should be packaged, or only the Python 3 version, depending on the functionality they provide.
(Note the "should": having Python 2-only executables is permitted, but strongly discouraged.)

Is it intentional for this particular package?

In case it is not intentional, please provide a Python 3 version of executable, or you can just switch to Python 3 if the functionality is the same regardless of the Python version. The guide for porting Python-based RPMs is available here [1] and you may refer to it for more instructions.

It's ok to do this in Rawhide only, however, it would be greatly
appreciated if you could push it to Fedora 26 as well.

If anything is unclear, or if you need any kind of assistance, you can
ask on IRC (#fedora-python on Freenode), or reply here. We'll be happy
to help investigating or fixing the issue!

[0] https://fedoraproject.org/wiki/Packaging:Python#Avoiding_collisions_between_the_python_2_and_python_3_stacks
[1] http://python-rpm-porting.readthedocs.io/

Comment 1 Jan Beran 2017-08-04 12:10:48 UTC
Created attachment 1309032 [details]
Latest Python3 upstream version

New 0.30.3 version (Python 3 only)

Comment 2 Jan Beran 2017-08-04 12:11:50 UTC
Hello Jose,

may I ask you to review the updated spec file, and if it is correct, to make a new Fedora build? Thank you.

Comment 3 José Matos 2017-08-06 18:53:41 UTC
(In reply to Jan Beran from comment #2)
> Hello Jose,
> 
> may I ask you to review the updated spec file, and if it is correct, to make
> a new Fedora build? Thank you.

Please do. Probably you need permission (unless you are a provenpackager).

And you are right, since 0.30 that it says to only support python 3.
http://pydoit.org/#project-details

The question then becomes what to do with the python2 subpackage...

Comment 4 José Matos 2017-08-06 18:56:55 UTC
(In reply to Iryna Shcherbina from comment #0)
> The Python 3 subpackage python3-doit is missing executables available in the
> Python 2 subpackage.
> 
> According to the Fedora Packaging guidelines for Python [0], if a Python
> package that supports Python 3 installs executables into /usr/bin,  then
> either both Python versions of the executables should be packaged, or only
> the Python 3 version, depending on the functionality they provide.
> (Note the "should": having Python 2-only executables is permitted, but
> strongly discouraged.)
> 
> Is it intentional for this particular package?
> 
> In case it is not intentional, please provide a Python 3 version of
> executable, or you can just switch to Python 3 if the functionality is the
> same regardless of the Python version. The guide for porting Python-based
> RPMs is available here [1] and you may refer to it for more instructions.
> 
> It's ok to do this in Rawhide only, however, it would be greatly
> appreciated if you could push it to Fedora 26 as well.
> 
> If anything is unclear, or if you need any kind of assistance, you can
> ask on IRC (#fedora-python on Freenode), or reply here. We'll be happy
> to help investigating or fixing the issue!
> 
> [0]
> https://fedoraproject.org/wiki/Packaging:
> Python#Avoiding_collisions_between_the_python_2_and_python_3_stacks
> [1] http://python-rpm-porting.readthedocs.io/

Apologies for taking so long to reply. :-(

You are right regarding the python3 binary, it was just inertia that kept me from updating the binary.

So it was not intentional, actually I wanted to do the change for some time but then Real Live (R) come. :-)

Thank you for reporting this issue.

Comment 5 Lumír Balhar 2017-08-09 09:22:51 UTC
Hello.

Patch from Jan looks good to me but unfortunately, it cannot be pushed because the newest version of doit comes with a new dependency - cloudpickle - which is not available in Fedora.

I am working on a new package python-cloudpickle and when it will be available in Fedora, we can move this forward.

Comment 6 Jan Kurik 2017-08-15 08:26:09 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle.
Changing version to '27'.

Comment 7 Lumír Balhar 2017-08-24 13:43:15 UTC
PR with all changes created: https://src.fedoraproject.org/rpms/python-doit/pull-request/1

Comment 8 Jan Beran 2017-09-18 13:40:44 UTC
Hello Jose, please, could you push the change?

Comment 9 Miro Hrončok 2017-10-12 13:28:32 UTC
merged

Comment 10 Miro Hrončok 2017-10-12 13:35:39 UTC
Built in rawhide. Reopen if older Fedoras are needed.

Comment 11 José Matos 2018-08-27 19:26:45 UTC
(In reply to Miro Hrončok from comment #9)
> merged

Thanks Miro.

I need to reply in order to properly close this bug.


Note You need to log in before you can comment on or make changes to this bug.