Bug 1436936 - parameter state->size is wrong in server3_3_writev
Summary: parameter state->size is wrong in server3_3_writev
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: protocol
Version: mainline
Hardware: All
OS: All
high
medium
Target Milestone: ---
Assignee: Zhou Zhengping
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-29 03:29 UTC by Zhou Zhengping
Modified: 2017-05-30 18:48 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.11.0
Clone Of:
Environment:
Last Closed: 2017-05-30 18:48:21 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Zhou Zhengping 2017-03-29 03:29:25 UTC
Description of problem:

state->size has been setted twice in server3_3_writev:

first:
        state->resolve.type  = RESOLVE_MUST;
        state->resolve.fd_no = args.fd;
        state->offset        = args.offset;
        state->size          = args.size;
        state->flags         = args.flag;
        state->iobref        = iobref_ref (req->iobref);
        memcpy (state->resolve.gfid, args.gfid, 16); 
second:
        for (i = 1; i < req->count; i++) {
                state->payload_vector[state->payload_count++]
                        = req->msg[i];
        } 

cause :
state->size will double

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-03-29 03:46:48 UTC
REVIEW: https://review.gluster.org/16962 (protocol: corect parameter state->size in server3_3_writev) posted (#1) for review on master by Zhou Zhengping (johnzzpcrystal)

Comment 2 Worker Ant 2017-04-02 04:34:27 UTC
COMMIT: https://review.gluster.org/16962 committed in master by Raghavendra G (rgowdapp) 
------
commit 64fc3505c426d1ff9fc16f065a81556e96ed93b7
Author: Zhou Zhengping <johnzzpcrystal>
Date:   Wed Mar 29 11:40:43 2017 +0800

    protocol: corect parameter state->size in server3_3_writev
    
    Change-Id: I1a3d558670e4320fe8508b5ab97deff9aacca5c7
    BUG: 1436936
    Signed-off-by: Zhou Zhengping <johnzzpcrystal>
    Reviewed-on: https://review.gluster.org/16962
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 3 Shyamsundar 2017-05-30 18:48:21 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.