Bug 1436980

Created attachment 1267244 [details]
Logs

Description of problem:
Failed to hot unplug vNIC if was added with duplicated MAC address to the same VM.

When adding a vNIC to a VM with a duplicated MAC address(duplicate is allowed), it's not possible to hot unplug it.

2017-03-29 10:40:19,509+0300 INFO  (jsonrpc/1) [virt.vm] (vmId='78ae390d-ffba-4116-b3f7-5fdf39cbdd62') Hotunplug NIC xml: <?xml version='1.0' encoding='UTF-8'?>
<interface type="bridge">
    <address bus="0x00" domain="0x0000" function="0x0" slot="0x0a" type="pci" />
    <mac address="00:00:00:00:00:15" />
    <model type="virtio" />
    <source bridge="ovirtmgmt" />
    <filterref filter="vdsm-no-mac-spoofing" />
    <link state="up" />
    <bandwidth />
</interface>
 (vm:2460)
2017-03-29 10:40:19,521+0300 ERROR (jsonrpc/1) [virt.vm] (vmId='78ae390d-ffba-4116-b3f7-5fdf39cbdd62') Hotunplug failed (vm:2492)
Traceback (most recent call last):
  File "/usr/share/vdsm/virt/vm.py", line 2482, in hotunplugNic
    self._dom.detachDevice(nicXml)
  File "/usr/lib/python2.7/site-packages/vdsm/virt/virdomain.py", line 69, in f
    ret = attr(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/vdsm/libvirtconnection.py", line 123, in wrapper
    ret = f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 941, in wrapper
    return func(inst, *args, **kwargs)
  File "/usr/lib64/python2.7/site-packages/libvirt.py", line 1143, in detachDevice
    if ret == -1: raise libvirtError ('virDomainDetachDevice() failed', dom=self)
libvirtError: operation failed: no device matching mac address 00:00:00:00:00:15 found on 0000:00:0a.0
2017-03-29 10:40:19,536+0300 INFO  (jsonrpc/1) [vdsm.api] FINISH hotunplugNic return={'status': {'message': 'operation failed: no device matching mac address 00:00:00:00:00:15 found on 0000:00:0a.0', 'code': 50}} 
(api:43)
2017-03-29 10:40:19,536+0300 INFO  (jsonrpc/1) [jsonrpc.JsonRpcServer] RPC call VM.hotunplugNic failed (error 50) in 0.04 seconds (__init__:515)
Version-Release number of selected component (if applicable):
4.1.1.6-0.1.el7

How reproducible:
100%

Steps to Reproduce:
1. Allow duplicate MAC addresses in the cluster and Add vNIC to a VM
2. Add vNIC as plugged with duplicated MAC address(same MAC from step1^^)
3. After was added, try to unplug.

Actual results:
Failed with error
libvirtError: operation failed: no device matching mac address 00:00:00:00:00:15 found on 0000:00:0a.0

Expected results:
Should work.