Bug 1437604 - 'container-storage-setup --reset' returns 'Info: command not found'
Summary: 'container-storage-setup --reset' returns 'Info: command not found'
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: container-storage-setup
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: smahajan@redhat.com
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-30 15:55 UTC by Micah Abbott
Modified: 2017-04-07 21:25 UTC (History)
6 users (show)

Fixed In Version: container-storage-setup-0.2.0-2.fc26
Clone Of:
Environment:
Last Closed: 2017-04-07 21:25:29 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Micah Abbott 2017-03-30 15:55:50 UTC
Using atomic-1.16.5-1.fc26.x86_64 from 'updates-testing'

'atomic storage reset' fails because it is looking for 'docker-storage-setup'

# atomic storage reset
/usr/bin/docker-storage-setup: line 1240: Info: command not found

# atomic --debug storage reset
/usr/bin/docker-storage-setup: line 1240: Info: command not found

Traceback (most recent call last):
  File "/usr/bin/atomic", line 189, in <module>
    sys.exit(_func())
  File "/usr/lib/python3.6/site-packages/Atomic/storage.py", line 159, in reset
    util.check_call(["docker-storage-setup", "--reset"], stdout=DEVNULL)
  File "/usr/lib/python3.6/site-packages/Atomic/util.py", line 141, in check_call
    return subprocess.check_call(cmd, env=env, stdin=stdin, stderr=stderr, stdout=stdout, close_fds=True)
  File "/usr/lib64/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['docker-storage-setup', '--reset']' returned non-zero exit status 127.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/atomic", line 202, in <module>
    sys.exit(e.returncode)
SystemExit: 127

Comment 1 Micah Abbott 2017-03-30 16:05:40 UTC
Oh, /usr/bin/docker-storage-setup is symlinked to /usr/bin/container-storage-setup

So this is actually an issue with 'container-storage-setup'

# container-storage-setup --reset
/usr/bin/container-storage-setup: line 1240: Info: command not found

# awk '{if(NR==1240) print $0}' /usr/bin/container-storage-setup
  Info "Volume group backing root filesystem could not be determined"

???

Comment 2 Micah Abbott 2017-03-30 16:06:08 UTC
# rpm -q container-storage-setup
container-storage-setup-0.1.0-2.fc26.noarch

Comment 3 smahajan@redhat.com 2017-04-03 14:31:16 UTC
Can you paste the contents of `/etc/sysconfig/docker-storage-setup` on the failing machine?

Shishir

Comment 4 Micah Abbott 2017-04-03 14:52:32 UTC
# cat /etc/sysconfig/docker-storage-setup 
# Edit this file to override any configuration options specified in
# /usr/share/container-storage-setup/container-storage-setup.
#
# For more details refer to "man container-storage-setup"
STORAGE_DRIVER=overlay2

Comment 5 smahajan@redhat.com 2017-04-03 14:54:58 UTC
Thanks. Can you also paste the output of the following commands?

1) lvs
2) vgs
3) pvs
4) lsblk
5) cat /etc/os-release

Shishir

Comment 6 Micah Abbott 2017-04-03 14:56:07 UTC
# lvs
# vgs
# pvs
# lsblk
NAME   MAJ:MIN RM  SIZE RO TYPE MOUNTPOINT
sr0     11:0    1  366K  0 rom  
vda    252:0    0   20G  0 disk 
├─vda1 252:1    0   50M  0 part /boot/efi
└─vda2 252:2    0   20G  0 part /
# cat /etc/os-release 
NAME=Fedora
VERSION="26 (Cloud Edition)"
ID=fedora
VERSION_ID=26
PRETTY_NAME="Fedora 26 (Cloud Edition)"
ANSI_COLOR="0;34"
CPE_NAME="cpe:/o:fedoraproject:fedora:26"
HOME_URL="https://fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=26
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=26
PRIVACY_POLICY_URL=https://fedoraproject.org/wiki/Legal:PrivacyPolicy
VARIANT="Cloud Edition"
VARIANT_ID=cloud

Comment 8 smahajan@redhat.com 2017-04-03 16:10:53 UTC
Okay, so this seems to be a packaging issue.

In container-storage-setup upstream/master code, libcss.sh is installed in /usr/share/container-storage-setup/libcss.sh
https://github.com/projectatomic/container-storage-setup/blob/master/Makefile#L32

and the script sources it from there.
https://github.com/projectatomic/container-storage-setup/blob/master/container-storage-setup.sh#L1267

However, in the failed environment.

/usr/bin/container-storage-setup is trying to source:
>>  source /usr/lib/container-storage-setup/libcss.sh
and the file is installed at /usr/share/container-storage-setup/libcss.sh

Since the script doesn't find the file, it is not able to recognize the INFO command and throws the error.

Lokesh, can you take a look on this ?

Shishir

Comment 9 Lokesh Mandvekar 2017-04-03 20:18:46 UTC
Could you try the scratch build at https://koji.fedoraproject.org/koji/taskinfo?taskID=18770735 ?

Comment 10 Micah Abbott 2017-04-03 20:43:49 UTC
Looks good here.  (That error is expected.)

# container-storage-setup --reset
INFO: Volume group backing root filesystem could not be determined

Comment 11 Daniel Walsh 2017-04-04 06:09:00 UTC
That is an info message, which we should eat if we are not using devicemapper.

Comment 12 Fedora Update System 2017-04-04 13:27:22 UTC
container-storage-setup-0.2.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b445dbe5e7

Comment 13 Fedora Update System 2017-04-04 23:53:18 UTC
container-storage-setup-0.2.0-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b445dbe5e7

Comment 14 Fedora Update System 2017-04-07 21:25:29 UTC
container-storage-setup-0.2.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.