Bug 1437611
| Summary: | activation and major/minor num change in one cmd is no longer possible | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Corey Marthaler <cmarthal> |
| Component: | lvm2 | Assignee: | Heinz Mauelshagen <heinzm> |
| lvm2 sub component: | Activating existing Logical Volumes | QA Contact: | cluster-qe <cluster-qe> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | low | ||
| Priority: | unspecified | CC: | agk, heinzm, jbrassow, msnitzer, prajnoha, prockai, teigland, zkabelac |
| Version: | 7.4 | ||
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | lvm2-2.02.170-2.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-01 21:52:19 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Corey Marthaler
2017-03-30 16:22:33 UTC
Upstream commit d6ddacf6a1543ba690fc349fad4c0c05cad1183b We should check all the other valid arg combinations in lvchange too, in particular everything else that this combination of -a and -M can be mixed with. (In reply to Heinz Mauelshagen from comment #2) > Upstream commit d6ddacf6a1543ba690fc349fad4c0c05cad1183b This incorrectly makes the activate option required; it needs to be optional, like this: lvchange --persistent y --minor Number LV -OO: --major Number, OO_LVCHANGE +OO: --major Number, --activate Active, OO_LVCHANGE ID: lvchange_persistent DESC: Make the minor device number persistent for an LV. RULE: all not LV_thinpool LV_cachepool (also the commit mistakenly changed major to minor in OO:) The addition of the new cmd def for persistent n is unnecessary because that's already included in OO_LVCHANGE_META. So, the diff above should be all that is needed to handle the original description. Dave, as is the combinations w/ and w/o -a all work. I'll try your proposal to make sure... Dave, tested and your proposal is good. The major change didn't cause any issues, because --major is dealt with earlier. Pushing your change. Fix verified in the latest rpms. 3.10.0-663.el7.x86_64 lvm2-2.02.171-1.el7 BUILT: Wed May 3 07:05:13 CDT 2017 lvm2-libs-2.02.171-1.el7 BUILT: Wed May 3 07:05:13 CDT 2017 lvm2-cluster-2.02.171-1.el7 BUILT: Wed May 3 07:05:13 CDT 2017 device-mapper-1.02.140-1.el7 BUILT: Wed May 3 07:05:13 CDT 2017 device-mapper-libs-1.02.140-1.el7 BUILT: Wed May 3 07:05:13 CDT 2017 device-mapper-event-1.02.140-1.el7 BUILT: Wed May 3 07:05:13 CDT 2017 device-mapper-event-libs-1.02.140-1.el7 BUILT: Wed May 3 07:05:13 CDT 2017 device-mapper-persistent-data-0.7.0-0.1.rc6.el7 BUILT: Mon Mar 27 10:15:46 CDT 2017 [root@host-073 ~]# dmsetup ls VG-foo (253:2) [root@host-073 ~]# lvchange -ay -f -My --major 255 --minor 164 /dev/VG/foo WARNING: Ignoring supplied major number 255 - kernel assigns major numbers dynamically. Using major number 253 instead. WARNING: Combining activation change with other commands is not advised. [root@host-073 ~]# dmsetup ls VG-foo (253:164) Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:2222 |