Description of problem: Working on OpenStack Cinder/Nova development: attaching and detaching iSCSI volumes that use LUKS encryption. Version-Release number of selected component: libvirt-daemon-2.2.0-2.fc25 Additional info: reporter: libreport-2.8.0 backtrace_rating: 4 cmdline: /usr/sbin/libvirtd crash_function: qemuDomainSecretDiskPrepare executable: /usr/sbin/libvirtd global_pid: 14515 kernel: 4.9.7-201.fc25.x86_64 pkg_fingerprint: 4089 D8F2 FDB1 9C98 pkg_vendor: Fedora Project runlevel: N 3 type: CCpp uid: 0 Truncated backtrace: Thread no. 1 (10 frames) #0 qemuDomainSecretDiskPrepare at qemu/qemu_domain.c:1091 #1 qemuDomainAttachVirtioDiskDevice at qemu/qemu_hotplug.c:355 #2 qemuDomainAttachDeviceDiskLive at qemu/qemu_hotplug.c:881 #3 qemuDomainAttachDeviceLive at qemu/qemu_driver.c:7469 #4 qemuDomainAttachDeviceLiveAndConfig at qemu/qemu_driver.c:8259 #5 qemuDomainAttachDeviceFlags at qemu/qemu_driver.c:8315 #6 virDomainAttachDeviceFlags at libvirt-domain.c:8416 #7 remoteDispatchDomainAttachDeviceFlags at remote_dispatch.h:3461 #8 remoteDispatchDomainAttachDeviceFlagsHelper at remote_dispatch.h:3437 #9 virNetServerProgramDispatchCall at rpc/virnetserverprogram.c:437
Created attachment 1267953 [details] File: backtrace
Created attachment 1267954 [details] File: cgroup
Created attachment 1267955 [details] File: core_backtrace
Created attachment 1267956 [details] File: dso_list
Created attachment 1267957 [details] File: environ
Created attachment 1267958 [details] File: exploitable
Created attachment 1267959 [details] File: limits
Created attachment 1267960 [details] File: maps
Created attachment 1267961 [details] File: mountinfo
Created attachment 1267962 [details] File: namespaces
Created attachment 1267963 [details] File: open_fds
Created attachment 1267964 [details] File: proc_pid_status
Created attachment 1267965 [details] File: var_log_messages
The following commit should fix the issue: commit 7f7d99048350935a394d07b98a13d7da9c4b0502 Author: John Ferlan <jferlan> Date: Thu Dec 22 07:12:49 2016 -0500 qemu: Don't assume secret provided for LUKS encryption ... If a secret was not provided for what was determined to be a LUKS encrypted disk (during virStorageFileGetMetadata processing when called from qemuDomainDetermineDiskChain as a result of hotplug attach qemuDomainAttachDeviceDiskLive), then do not attempt to look it up (avoiding a libvirtd crash) and do not alter the format to "luks" when adding the disk; otherwise, the device_add would fail with a message such as: "unable to execute QEMU command 'device_add': Property 'scsi-hd.drive' can't find value 'drive-scsi0-0-0-0'" because of assumptions that when the format=luks that libvirt would have provided the secret to decrypt the volume. Access to unlock the volume will thus be left to the application. $ git describe 7f7d99048350935a394d07b98a13d7da9c4b0502 v2.5.0-284-g7f7d990 $ Fedora 26 should already contain the fixed package.
libvirt-2.2.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b67f65db3
libvirt-2.2.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b67f65db3
libvirt-2.2.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.