Bug 143808 - couple of minor problems
Summary: couple of minor problems
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: s390utils
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Phil Knirsch
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-12-28 14:49 UTC by David Binderman
Modified: 2015-03-05 01:14 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-09-06 14:58:41 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description David Binderman 2004-12-28 14:49:12 UTC
Description of problem:

I just tried to compile package s390utils-1.3.2-3 from 
Redhat Fedora development tree.

The compiler said

1.

xcec-bridge.c(444): warning #187: use of "=" where "==" may have been
intended

The source code is

	if ( (errno=EMSGSIZE) && (!i_s_item->mtu_warning) ) {

Deeply suspicious code. Suggest 

	if ( (errno == EMSGSIZE) && (!i_s_item->mtu_warning) ) {

is better code.

2.

cmsfsvol.c(55): warning #269: invalid format string conversion

The source code is

    (void) printf("LABEL  VDEV M  STAT   CYL TYPE \
BLKSZ   FILES  BLKS USED-(%) BLKS LEFT  BLK TOTAL\n");

%) isn't a valid specifier for printf. Suggest use %% for %.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Phil Knirsch 2005-09-06 14:58:41 UTC
Fixed in latest development version.

Read ya, Phil


Note You need to log in before you can comment on or make changes to this bug.