Created attachment 1268209 [details]
engine & vdsm logs

Description of problem:
After cold migration/move of Vm's disk+snapshots to V4 storage domain , migrated snapshots disks are still with qcow2_v2.
Disk is upgraded to qcow2_v3 as expected.


Version-Release number of selected component (if applicable):
Engine:
ovirt-engine-4.1.1.6-0.1.el7.noarch

VDSM:
4.19.6-1


How reproducible:
100%


Steps to Reproduce:
1. Create DC + cluster on v3 + 2 new storage domains
2. Create a VM with thin disk and create 2 snapshots
3. Upgrade the cluster+DC from v3 to v4
4. Verify that the snapshot images are version 0.10
5. Move all the disks of the VM to Version 4 Domain
6. Verify that the snapshot images have been upgraded to version 1.1
    
Actual results:
After migration of a Vm's disk+snapshots to V4 storage domain snapshots disks are with qcow2_v2.
Disk is upgraded to qcow2_v3.

Expected results:
After migration of a VM's disk+snapshots to V4 storage domain, I expect to get disk & snapshots disk are with qcow2_v3


Additional info:
Storage migration took place at 2017-04-02 14:32:39 & was successful.

from engine log:
Start of disk copy:
2017-04-02 14:32:39,392+03 INFO  [org.ovirt.engine.core.bll.storage.disk.MoveOrCopyDiskCommand
End of disk copy:
2017-04-02 14:35:12,503+03 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (DefaultQuartzScheduler10) [] EVENT_ID: USER_MOVED_DISK_FINISHED_SUCCESS(2,010), Correlation ID: disks_syncAction_a5d97ea7-6e3e-4822, Job ID: 6ae8098b-8559-49b5-bf2c-07bb7ef855de, Call Stack: null, Custom Event ID: -1, Message: User admin@internal-authz finished moving disk vm_TestCase18344_REST_NFS_0214312617_Disk_0 to domain upgrade_4_0_to_4_1nfs1.

Disk id="df9dfb37-ad7d-4d79-8ff3-ca7689e43147
snapshot1 id="b0c803a6-1d04-4292-91a3-8d4ce5fe62fb"
snapshot2 id="139edda1-a90f-41ea-bd7c-d5c6111ae4eb"

From https://storage-ge-04.scl.lab.tlv.redhat.com/ovirt-engine/api/storagedomains/07461a18-51f2-4c57-ad36-fa661b003946/disksnapshots


<disk_snapshots>
<disk_snapshot href="/ovirt-engine/api/storagedomains/272d1360-7071-4d31-981d-752c6b2cfdcf/disksnapshots/09a3e3da-9312-4183-bb9d-290a4f201eff" id="09a3e3da-9312-4183-bb9d-290a4f201eff">
<name>vm_TestCase18343_REST_NFS_3114284038_Disk_0</name>
<description>golden_env_mixed_virtio_0_Disk1 (d75e58e)</description>
<actual_size>200704</actual_size>
<alias>vm_TestCase18343_REST_NFS_3114284038_Disk_0</alias>
<format>cow</format>
<propagate_errors>false</propagate_errors>
<provisioned_size>10737418240</provisioned_size>
<qcow_version>qcow2_v2</qcow_version>
<shareable>false</shareable>
<sparse>true</sparse>
<status>ok</status>
<storage_type>image</storage_type>
<wipe_after_delete>false</wipe_after_delete>
<snapshot id="d336bb6e-dedb-4296-9afd-3e3ced4a769f"/>
<storage_domain href="/ovirt-engine/api/storagedomains/272d1360-7071-4d31-981d-752c6b2cfdcf" id="272d1360-7071-4d31-981d-752c6b2cfdcf"/>
<storage_domains>
<storage_domain id="272d1360-7071-4d31-981d-752c6b2cfdcf"/>
</storage_domains>
<disk href="/ovirt-engine/api/disks/22e8262c-39f2-40eb-ade1-46892bd478d3" id="22e8262c-39f2-40eb-ade1-46892bd478d3"/>
</disk_snapshot>
<disk_snapshot href="/ovirt-engine/api/storagedomains/272d1360-7071-4d31-981d-752c6b2cfdcf/disksnapshots/1a36008d-8172-4381-9dcb-49bbad991a0d" id="1a36008d-8172-4381-9dcb-49bbad991a0d">
<name>vm_TestCase18343_REST_NFS_3114284038_Disk_0</name>
<description>golden_env_mixed_virtio_0_Disk1 (d75e58e)</description>
<actual_size>200704</actual_size>
<alias>vm_TestCase18343_REST_NFS_3114284038_Disk_0</alias>
<format>cow</format>
<propagate_errors>false</propagate_errors>
<provisioned_size>10737418240</provisioned_size>
<qcow_version>qcow2_v2</qcow_version>
<shareable>false</shareable>
<sparse>true</sparse>
<status>ok</status>
<storage_type>image</storage_type>
<wipe_after_delete>false</wipe_after_delete>
<snapshot id="bede5c19-63d8-466b-8c2e-9e8b550bd550"/>
<storage_domain href="/ovirt-engine/api/storagedomains/272d1360-7071-4d31-981d-752c6b2cfdcf" id="272d1360-7071-4d31-981d-752c6b2cfdcf"/>
<storage_domains>
<storage_domain id="272d1360-7071-4d31-981d-752c6b2cfdcf"/>
</storage_domains>
<disk href="/ovirt-engine/api/disks/22e8262c-39f2-40eb-ade1-46892bd478d3" id="22e8262c-39f2-40eb-ade1-46892bd478d3"/>
</disk_snapshot>
</disk_snapshots>

From https://storage-ge-04.scl.lab.tlv.redhat.com/ovirt-engine/api/storagedomains/272d1360-7071-4d31-981d-752c6b2cfdcf/disks  :

<disks>
<disk href="/ovirt-engine/api/disks/22e8262c-39f2-40eb-ade1-46892bd478d3" id="22e8262c-39f2-40eb-ade1-46892bd478d3">
<actions>
<link href="/ovirt-engine/api/disks/22e8262c-39f2-40eb-ade1-46892bd478d3/sparsify" rel="sparsify"/>
<link href="/ovirt-engine/api/disks/22e8262c-39f2-40eb-ade1-46892bd478d3/export" rel="export"/>
<link href="/ovirt-engine/api/disks/22e8262c-39f2-40eb-ade1-46892bd478d3/move" rel="move"/>
<link href="/ovirt-engine/api/disks/22e8262c-39f2-40eb-ade1-46892bd478d3/copy" rel="copy"/>
</actions>
<name>vm_TestCase18343_REST_NFS_3114284038_Disk_0</name>
<description>golden_env_mixed_virtio_0_Disk1 (d75e58e)</description>
<link href="/ovirt-engine/api/disks/22e8262c-39f2-40eb-ade1-46892bd478d3/permissions" rel="permissions"/>
<link href="/ovirt-engine/api/disks/22e8262c-39f2-40eb-ade1-46892bd478d3/statistics" rel="statistics"/>
<actual_size>147660800</actual_size>
<alias>vm_TestCase18343_REST_NFS_3114284038_Disk_0</alias>
<format>cow</format>
<image_id>df24d641-cd7d-4913-86de-0287c78bfdc7</image_id>
<propagate_errors>false</propagate_errors>
<provisioned_size>10737418240</provisioned_size>
<qcow_version>qcow2_v2</qcow_version>
<shareable>false</shareable>
<sparse>true</sparse>
<status>ok</status>
<storage_type>image</storage_type>
<wipe_after_delete>false</wipe_after_delete>
<storage_domain href="/ovirt-engine/api/storagedomains/272d1360-7071-4d31-981d-752c6b2cfdcf" id="272d1360-7071-4d31-981d-752c6b2cfdcf"/>
<storage_domains>
<storage_domain href="/ovirt-engine/api/storagedomains/272d1360-7071-4d31-981d-752c6b2cfdcf" id="272d1360-7071-4d31-981d-752c6b2cfdcf"/>
</storage_domains>
</disk>