Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1438340

Summary:	glusterd is not validating for allowed values while setting "cluster.brick-multiplex" property
Product:	[Community] GlusterFS	Reporter:	Gaurav Yadav <gyadav>
Component:	glusterd	Assignee:	Gaurav Yadav <gyadav>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	3.10	CC:	amukherj, bugs, rtalur
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.10.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1425288	Environment:
Last Closed:	2017-05-31 20:45:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1425288
Bug Blocks:	1442603

Description Gaurav Yadav 2017-04-03 06:46:14 UTC

+++ This bug was initially created as a clone of Bug #1425288 +++

Description of problem:
glusterd is not validating for allowed values while setting "cluster.brick-multiplex"  property.
When glusterd set cluster.brick-multiplex property allowed values are on/off, but glusterd gives success message for all combination of string i.e 
gluster v set all cluster.brick-multiplex 12132131
gluster v set all cluster.brick-multiplex ababs

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a volume
2. gluster v set all cluster.brick-multiplex 12132131

Actual results:
glusterd gives success message for all the values

Expected results:
glusterd should error while setting unknown values.

Additional info:

--- Additional comment from Atin Mukherjee on 2017-02-21 06:40:09 EST ---

I don't see any patch posted against this bug, the status should be either in NEW or ASSIGNED.

--- Additional comment from Worker Ant on 2017-02-21 12:53:04 EST ---

REVIEW: https://review.gluster.org/16704 (glusterd : cluster.brick-multiplex validation is missing while setting it) posted (#1) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-02-22 00:28:14 EST ---

REVIEW: https://review.gluster.org/16704 (glusterd : cluster.brick-multiplex validation is missing while setting it) posted (#2) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-02-22 00:31:18 EST ---

REVIEW: https://review.gluster.org/16704 (glusterd : cluster.brick-multiplex validation is missing while setting it) posted (#3) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-02-22 00:42:39 EST ---

REVIEW: https://review.gluster.org/16704 (glusterd : cluster.brick-multiplex validation is missing while setting it) posted (#4) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-02-22 06:05:59 EST ---

COMMIT: https://review.gluster.org/16704 committed in master by Atin Mukherjee (amukherj) 
------
commit 60347526d9611035da0e56d55d4814f51cda9367
Author: Gaurav Yadav <gyadav>
Date:   Tue Feb 21 22:35:47 2017 +0530

    glusterd : cluster.brick-multiplex validation is missing while setting it
    
    Currently glusterd allow setting all values  while setting cluster.brick-multiplex
    option. Validation of allowed options is missing.
    
    With this patch glusterd will validate the values given while setting
    cluster.brick-multiplex.
    
    Change-Id: I938fb16b8f5faa9d31326373cd18632b8aa7ebab
    BUG: 1425288
    Signed-off-by: Gaurav Yadav <gyadav>
    Reviewed-on: https://review.gluster.org/16704
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 1 Worker Ant 2017-04-03 06:48:58 UTC

REVIEW: https://review.gluster.org/16982 (glusterd : cluster.brick-multiplex validation is missing while setting it) posted (#1) for review on release-3.10 by Gaurav Yadav (gyadav)

Comment 2 Worker Ant 2017-04-13 15:32:36 UTC

COMMIT: https://review.gluster.org/16982 committed in release-3.10 by Shyamsundar Ranganathan (srangana) 
------
commit 0726b768e83574ee0b08dbde10746c9015c7eb73
Author: Gaurav Yadav <gyadav>
Date:   Tue Feb 21 22:35:47 2017 +0530

    glusterd : cluster.brick-multiplex validation is missing while setting it
    
    Currently glusterd allow setting all values  while setting cluster.brick-multiplex
    option. Validation of allowed options is missing.
    
    With this patch glusterd will validate the values given while setting
    cluster.brick-multiplex.
    
    > Reviewed-on: https://review.gluster.org/16704
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Atin Mukherjee <amukherj>
    
    (cherry picked from commit 60347526d9611035da0e56d55d4814f51cda9367)
    
    Change-Id: I938fb16b8f5faa9d31326373cd18632b8aa7ebab
    BUG: 1438340
    Signed-off-by: Gaurav Yadav <gyadav>
    Reviewed-on: https://review.gluster.org/16982
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Samikshan Bairagya <samikshan>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Prashanth Pai <ppai>

Comment 3 Raghavendra Talur 2017-05-31 20:45:17 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.2, please open a new bug report.