1438457 – Lvconvert is not validating acceptable LV type at correct level

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1438457 - Lvconvert is not validating acceptable LV type at correct level

Summary: Lvconvert is not validating acceptable LV type at correct level

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	lvm2
Sub Component:
Version:	7.4
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	rc
Target Release:	---
Assignee:	LVM and device-mapper development team
QA Contact:	cluster-qe@redhat.com
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2017-04-03 13:05 UTC by Zdenek Kabelac
Modified:	2021-09-03 12:38 UTC (History)
CC List:	10 users (show)
Fixed In Version:	lvm2-2.02.170-2.el7
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2017-08-01 21:52:19 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2017:2222	0	normal	SHIPPED_LIVE	lvm2 bug fix and enhancement update	2017-08-01 18:42:41 UTC

Description Zdenek Kabelac 2017-04-03 13:05:43 UTC

Description of problem:

It seems ATM lvm2 169 is not properly rejecting this command:

lvconvert --thinpool vg/LV1_rimage_0


It should prohibit LV with _rimage_0 suffix at cmd line level.
But since this check has been lost - we let conversion running for rimage leg.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 David Teigland 2017-04-04 21:50:17 UTC

Fixed
https://sourceware.org/git/?p=lvm2.git;a=commit;h=76b70d5058cbbe41b60b99f11cda5e698b3c62e9

Comment 4 Corey Marthaler 2017-05-23 19:58:17 UTC

Fix verified with the latest rpms.

3.10.0-666.el7.x86_64
lvm2-2.02.171-1.el7    BUILT: Wed May  3 07:05:13 CDT 2017
lvm2-libs-2.02.171-1.el7    BUILT: Wed May  3 07:05:13 CDT 2017
lvm2-cluster-2.02.171-1.el7    BUILT: Wed May  3 07:05:13 CDT 2017
device-mapper-1.02.140-1.el7    BUILT: Wed May  3 07:05:13 CDT 2017
device-mapper-libs-1.02.140-1.el7    BUILT: Wed May  3 07:05:13 CDT 2017
device-mapper-event-1.02.140-1.el7    BUILT: Wed May  3 07:05:13 CDT 2017
device-mapper-event-libs-1.02.140-1.el7    BUILT: Wed May  3 07:05:13 CDT 2017
device-mapper-persistent-data-0.7.0-0.1.rc6.el7    BUILT: Mon Mar 27 10:15:46 CDT 2017


Attempted the following invalid meta convert combinations:
[root@host-126 ~]# lvs -a -o +devices
  LV                 VG            Attr       LSize   Pool Origin Data%  Meta% Cpy%Sync Devices
  invalid            snapper_thinp rwi-a-r--- 100.00m                          100.00   invalid_rimage_0(0),invalid_rimage_1(0)
  [invalid_rimage_0] snapper_thinp iwi-aor--- 100.00m                                   /dev/sdb1(26)
  [invalid_rimage_1] snapper_thinp iwi-aor--- 100.00m                                   /dev/sda1(1)
  [invalid_rmeta_0]  snapper_thinp ewi-aor---   4.00m                                   /dev/sdb1(25)
  [invalid_rmeta_1]  snapper_thinp ewi-aor---   4.00m                                   /dev/sda1(0)
  valid              snapper_thinp -wi-a----- 100.00m                                   /dev/sdb1(0)

[root@host-126 ~]#  lvconvert --yes --thinpool snapper_thinp/invalid_rimage_0
  Command on LV snapper_thinp/invalid_rimage_0 requires LV with properties: lv_is_visible .
  Command not permitted on LV snapper_thinp/invalid_rimage_0.

[root@host-126 ~]# lvconvert --yes --thinpool snapper_thinp/invalid_rimage_1 --poolmetadata valid
  Command on LV snapper_thinp/invalid_rimage_1 requires LV with properties: lv_is_visible .
  Command not permitted on LV snapper_thinp/invalid_rimage_1.

[root@host-126 ~]# lvconvert --yes --thinpool snapper_thinp/invalid_rmeta_1 --poolmetadata snapper_thinp/valid
  Command on LV snapper_thinp/invalid_rmeta_1 requires LV with properties: lv_is_visible .
  Command not permitted on LV snapper_thinp/invalid_rmeta_1.

[root@host-126 ~]# lvconvert --yes --thinpool snapper_thinp/valid --poolmetadata snapper_thinp/invalid_rimage_0
  Can't convert internal LV snapper_thinp/invalid_rimage_0.

[root@host-126 ~]# lvconvert --yes --thinpool snapper_thinp/valid --poolmetadata snapper_thinp/invalid_rmeta_0
  Can't convert internal LV snapper_thinp/invalid_rmeta_0.

Comment 5 errata-xmlrpc 2017-08-01 21:52:19 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2222

Note You need to log in before you can comment on or make changes to this bug.