RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1438735 - Windows' qemu-ga fails to set the 'can-offline' field in 'guest-get-vcpus' reply
Summary: Windows' qemu-ga fails to set the 'can-offline' field in 'guest-get-vcpus' reply
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: virtio-win
Version: 7.4
Hardware: Unspecified
OS: Windows
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Yvugenfi@redhat.com
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-04 10:20 UTC by Daniel Berrangé
Modified: 2017-08-01 12:58 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-01 12:58:08 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:2341 0 normal SHIPPED_LIVE virtio-win bug fix and enhancement update 2017-08-01 16:52:38 UTC

Description Daniel Berrangé 2017-04-04 10:20:24 UTC 
Description of problem:
The QGA schema says

# @can-offline: Whether offlining the VCPU is possible. This member
#               is always filled in by the guest agent when the structure is
#               returned, and always ignored on input (hence it can be omitted
#               then).

but the *Windows* implementation of 'guest-get-vcpus' simply does

             vcpu->has_can_offline = false;

which means 'can-offline' is missing entirely from the reply. This causes errors in libvirt which is expecting the reply to be compliant with the schema docs

error: internal error: 'can-offline' missing in reply of guest-get-vcpus

The guest agent code should be doing

             vcpu->has_can_offline = true;
             vcpu->can_offline = false;

Version-Release number of selected component (if applicable):
2.9.0
Comment 2 xiagao 2017-04-10 05:39:00 UTC 
Hi,

I tried to execute 'guest-get-vcpus' in qemu-ga-win-7.4.3-1.
{"execute":"guest-get-vcpus"}
{"return": [{"online": true, "logical-id": 0}, {"online": true, "logical-id": 1}, {"online": true, "logical-id": 2}, {"online": true, "logical-id": 3}]}

From comment 0, what will the expect result be in rhel7.4? And do we still not support 'guest-set-vcpus' in windows guest in rhel7.4?

I noticed that rhel guest's result is like following:
 {"return":[{"online":true,"can-offline":true,"logical-id":0},{"online":true,"can-offline":true,"logical-id":1}...

Is the result expected in windows guest like this?
{"return":[{"online":true,"can-offline":false,"logical-id":0},{"online":true,"can-offline":false,"logical-id":1}...


Thanks,
xiagao
Comment 3 Yvugenfi@redhat.com 2017-04-12 09:02:28 UTC 
There is no support for guest-set-vcpus  in Windows.

Can offline should be false.
Comment 5 xiagao 2017-06-09 05:49:51 UTC 
verified this bug on qemu-ga-win-7.4.5-1

{"execute":"guest-get-vcpus"}
{"return": [{"online": true, "can-offline": false, "logical-id": 0}, {"online": true, "can-offline": false, "logical-id": 1}]}
Comment 7 errata-xmlrpc 2017-08-01 12:58:08 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2341
Note You need to log in before you can comment on or make changes to this bug.