Bug 1438772 - build: clang/llvm has __builtin_ffs() and __builtin_popcount()
Summary: build: clang/llvm has __builtin_ffs() and __builtin_popcount()
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kaleb KEITHLEY
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-04 11:46 UTC by Kaleb KEITHLEY
Modified: 2017-05-30 18:49 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.11.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-30 18:49:22 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kaleb KEITHLEY 2017-04-04 11:46:46 UTC
Description of problem:

No reason to penalize clang compiled, use the built-in functions

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-04-04 11:59:12 UTC
REVIEW: https://review.gluster.org/16993 (build: clang has __builtin_popcount() and __builtin_ffs()) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 2 Worker Ant 2017-04-04 16:14:45 UTC
REVIEW: https://review.gluster.org/16993 (build: clang has __builtin_popcount() and __builtin_ffs()) posted (#3) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 3 Worker Ant 2017-04-05 06:12:56 UTC
COMMIT: https://review.gluster.org/16993 committed in master by Xavier Hernandez (xhernandez) 
------
commit 1063efeb2275039a75eb6fe5e423845e28098df2
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Tue Apr 4 07:35:52 2017 -0400

    build: clang has __builtin_popcount() and __builtin_ffs()
    
    Note: Even though gcc(1) will automatically treat ffs() and popcount()
    as built-in, calling them explicitly as __builtin in the source helps
    make it easier to find them. (And if no __builtin_ffs use the one in
    libc.)
    
    Change-Id: Ib74d9b221ff03a01df5ad05907024da1a83a7a88
    BUG: 1438772
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: https://review.gluster.org/16993
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jeff.us>
    Reviewed-by: Xavier Hernandez <xhernandez>

Comment 4 Shyamsundar 2017-05-30 18:49:22 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.