Bug 1438935 - Excessive log lines for "Initializing DRb Connection to MiqServer with ID"
Summary: Excessive log lines for "Initializing DRb Connection to MiqServer with ID"
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Appliance
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: GA
: 5.9.0
Assignee: Joe Rafaniello
QA Contact: luke couzens
URL:
Whiteboard: black
: 1439262 (view as bug list)
Depends On:
Blocks: 1439303 1439308
TreeView+ depends on / blocked
 
Reported: 2017-04-04 19:34 UTC by Joe Rafaniello
Modified: 2018-03-06 15:17 UTC (History)
4 users (show)

Fixed In Version: 5.9.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1439303 1439308 (view as bug list)
Environment:
Last Closed: 2018-03-06 15:17:16 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Joe Rafaniello 2017-04-04 19:34:31 UTC
Description of problem:
Whenever a queue message is fetched from the server process, we now log a "Initializing DRb Connection" message.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Upgrade to an appliance with fine-1-beta1
2. Start server
3. Each time a worker fetches a queue message, a new DRb client is created and log line below is seen:

"Initializing DRb Connection to MiqServer with ID"



Additional info:
Was introduced in: https://github.com/ManageIQ/manageiq/pull/14365
In commit: https://github.com/ManageIQ/manageiq/commit/e21d1b9ca747cdbdf9c90484e47f7a25ed161d6b
for BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1429747

Comment 2 Joe Rafaniello 2017-04-04 19:48:00 UTC
Note, https://github.com/ManageIQ/manageiq/pull/14365 was backported to euwe, so we should clone to 5.7.

Comment 4 CFME Bot 2017-04-04 22:26:34 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/a9726db194068853599ee173334e5920b7cfe5bd

commit a9726db194068853599ee173334e5920b7cfe5bd
Author:     Joe Rafaniello <jrafanie>
AuthorDate: Tue Apr 4 14:59:57 2017 -0400
Commit:     Joe Rafaniello <jrafanie>
CommitDate: Tue Apr 4 16:08:04 2017 -0400

    Make worker_monitor_drb act like a reader again!
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1438935
    
    For testing in e21d1b9ca, @worker_monitor_drb was changed to use the
    method.  Unfortunately, this method isn't a reader, so it would create a
    new drb client each time it was called.
    
    It doesn't make sense for this method to make a new drb client each
    time, so we can cache this client on first access so it functions like a
    attr_reader now.  We can then remove some memoization/caching that
    occurs in heartbeat since the getter method handles that for us.

 app/models/miq_worker/runner.rb       | 29 +++++++++++++++--------------
 spec/models/miq_worker/runner_spec.rb |  8 ++++++++
 2 files changed, 23 insertions(+), 14 deletions(-)

Comment 7 Joe Rafaniello 2017-04-05 18:52:35 UTC
Making this a blocker since it floods the logs.  Additionally, it creates a new DRb client each time we process a queue message.

Comment 8 Joe Rafaniello 2017-04-05 18:56:04 UTC
Ugh, wrong bug, removing blocker

Comment 9 Gregg Tanzillo 2017-04-05 19:11:11 UTC
*** Bug 1439262 has been marked as a duplicate of this bug. ***

Comment 10 luke couzens 2017-10-24 08:02:34 UTC
Verified in 5.9.0.3


Note You need to log in before you can comment on or make changes to this bug.