Bug 1439514 - dnf config-manager --add-repo returns 0 on failure
Summary: dnf config-manager --add-repo returns 0 on failure
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: dnf-plugins-core
Version: 25
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: ---
Assignee: Jaroslav Mracek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1493489
TreeView+ depends on / blocked
 
Reported: 2017-04-06 07:05 UTC by Ihar Hrachyshka
Modified: 2017-09-20 10:36 UTC (History)
4 users (show)

Fixed In Version: dnf-plugins-core-2.1.3-1.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1493489 (view as bug list)
Environment:
Last Closed: 2017-07-25 16:55:10 UTC


Attachments (Terms of Use)

Description Ihar Hrachyshka 2017-04-06 07:05:21 UTC
[vagrant@localhost ~]$ sudo dnf config-manager --add-repo=http://download.devel.redhat.com/rel-eng/dist-git/fedora/rhpkg.repo
Adding repo from: http://download.devel.redhat.com/rel-eng/dist-git/fedora/rhpkg.repo
Curl error (6): Couldn't resolve host name for http://download.devel.redhat.com/rel-eng/dist-git/fedora/rhpkg.repo [Could not resolve host: download.devel.redhat.com]
[vagrant@localhost ~]$ echo $?
0

I believe it should return some other value on failure.

Comment 1 Honza Silhan 2017-04-12 11:12:53 UTC
The behavior is same as in yum.

Valentina, what do you think? Can we set this as a bug and have this fixed in yum too?

Comment 2 Valentina Mukhamedzhanova 2017-05-02 15:11:07 UTC
I have no objection to fixing this.

Comment 3 Jaroslav Mracek 2017-06-19 18:46:22 UTC
I created a pull-request that should fix the issue (https://github.com/rpm-software-management/dnf-plugins-core/pull/225).

Comment 4 Fedora Update System 2017-07-24 14:50:14 UTC
libdnf-0.9.3-1.fc26 dnf-plugins-core-2.1.3-1.fc26 dnf-2.6.2-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6f4c06b2d7

Comment 5 Fedora Update System 2017-07-25 04:26:23 UTC
dnf-2.6.2-1.fc26, dnf-plugins-core-2.1.3-1.fc26, libdnf-0.9.3-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6f4c06b2d7

Comment 6 Fedora Update System 2017-07-25 16:55:10 UTC
dnf-2.6.2-1.fc26, dnf-plugins-core-2.1.3-1.fc26, libdnf-0.9.3-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.