Bug 1439527 - [disperse] Don't count healing brick as healthy brick
Summary: [disperse] Don't count healing brick as healthy brick
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: disperse
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ashish Pandey
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-06 07:51 UTC by Ashish Pandey
Modified: 2017-05-30 18:49 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.11.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-30 18:49:22 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ashish Pandey 2017-04-06 07:51:55 UTC
Description of problem:

    
    In ec_child_select, we should send fop on healing bricks
    unconditionaly but to check  the number of healthy bricks
    against fragments and minimum count, we should not count
    these healing bricks.
    
    Count bits of fop->mask before adding ealing brick to
    fop->mask
    


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-04-06 08:13:51 UTC
REVIEW: https://review.gluster.org/17007 (cluster/ec : Don't count healing brick as healthy brick) posted (#1) for review on master by Ashish Pandey (aspandey)

Comment 2 Worker Ant 2017-04-06 08:15:36 UTC
REVIEW: https://review.gluster.org/17007 (cluster/ec : Don't count healing brick as healthy brick) posted (#2) for review on master by Ashish Pandey (aspandey)

Comment 3 Worker Ant 2017-04-11 11:50:00 UTC
REVIEW: https://review.gluster.org/17007 (cluster/ec : Don't count healing brick as healthy brick) posted (#3) for review on master by Ashish Pandey (aspandey)

Comment 4 Worker Ant 2017-04-12 11:51:08 UTC
COMMIT: https://review.gluster.org/17007 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit e536bea09aa0776164716f9a0d480584c0a761f2
Author: Ashish Pandey <aspandey>
Date:   Wed Apr 5 17:13:25 2017 +0530

    cluster/ec : Don't count healing brick as healthy brick
    
    In ec_child_select, we should send fop on healing bricks
    unconditionaly but to check  the number of healthy bricks
    against fragments and minimum count, we should not count
    these healing bricks.
    
    Count bits of fop->mask before adding ealing brick to
    fop->mask
    
    Change-Id: I3fa80bdd5ca34ca070d610116b84154b917c5999
    BUG: 1439527
    Signed-off-by: Ashish Pandey <aspandey>
    Reviewed-on: https://review.gluster.org/17007
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 5 Shyamsundar 2017-05-30 18:49:22 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.