Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1440230

Summary:	[RFE] Allow "Pass discard from guest to underlying storage" for Cinder.
Product:	[oVirt] ovirt-engine	Reporter:	Konstantin Shalygin <shalygin.k>
Component:	General	Assignee:	bugs <bugs>
Status:	CLOSED WONTFIX	QA Contact:	Elad <ebenahar>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	4.2.7	CC:	bugs, dfediuck, shalygin.k, tnisan
Target Milestone:	---	Keywords:	FutureFeature, Improvement
Target Release:	---	Flags:	ylavi: ovirt-future? rule-engine: planning_ack? rule-engine: devel_ack? rule-engine: testing_ack?
Hardware:	x86_64
OS:	Linux
URL:	http://www.ovirt.org/develop/release-management/features/storage/pass-discard-from-guest-to-underlying-storage/
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-05-20 07:17:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Konstantin Shalygin 2017-04-07 15:36:44 UTC

Description of problem:

oVirt 4.1 support discard from gust OS to storage backend. Ceph as Cinder backend support trimming rbd images to.
I avoid this the lack of 'discard' option via 'diskunmap' (https://github.com/oVirt/vdsm/tree/master/vdsm_hooks/diskunmap) vdsm hook and all works as expected. When fstrim is called in VM (or disk mounted with 'discard' option) - Ceph start reclaim unused space.

Version-Release number of selected component (if applicable): 4.1.1.6


How reproducible:


Steps to Reproduce:
1. (On Web Admin) Select VM -> Edit.
2. General -> Instance Images -> Create.
3. Select 'Cinder'.

Actual results:

No "Enable Discard" option.

Expected results:

"Enable Discard: option is present.

Additional info:


Priority low, because can be avoid via vdsm hook (who come from google see description).

Comment 1 Allon Mureinik 2017-04-09 11:01:38 UTC

Like with file-based disks, we can (should) treat this as a best-effort attempt.

Comment 3 Konstantin Shalygin 2019-01-09 11:47:42 UTC

Still missed feature in oVirt 4.2

Comment 4 Tal Nisan 2019-05-20 07:17:23 UTC

Since moving to Cinderlib as tech preview in RHV 4.3 we deprecated the Cinder storage domains