Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1440245

Summary: the migrate script was not updated to account for the min master change
Product: OpenShift Container Platform Reporter: Eric Jones <erjones>
Component: LoggingAssignee: Jeff Cantrill <jcantril>
Status: CLOSED DUPLICATE QA Contact: Xia Zhao <xiazhao>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 3.4.1CC: akokshar, aos-bugs, bvincell, erjones, jcantril, kurktchiev, pportant, rromerom, sdodson, xiazhao
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1439554 Environment:
Last Closed: 2017-04-18 15:50:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1439356, 1439554    
Bug Blocks:    
Attachments:
Description Flags
ElasticSearch Trace provided by customer none

Description Eric Jones 2017-04-07 16:24:54 UTC
Created attachment 1269815 [details]
ElasticSearch Trace provided by customer

+++ This bug was initially created as a clone of Bug #1439554 +++

Description of problem:
When upgrading from 3.4.0 to 3.4.1-17 the following error is shown and the deployment fails.

Could not resolve placeholder 'MIN_MASTERS'

Version-Release number of selected component (if applicable):
Openshift 3.4.1.10
openshift3-logging-elasticsearch-3.4.1-17

How reproducible:
Always

Steps to Reproduce:
1. oc new-app logging-deployer-template --param IMAGE_VERSION=3.4.1 --param MODE=upgrade

Actual results:
The metrics fail to deploy because the ENV variable MIN_MASTERS is not present in the deployment config for logging-es-xxxx

Expected results:
The metrics are upgraded to the latest version and the deployment config includes the MIN_MASTERS environment variable defined.

Additional info:
By manually adding the variable, the deployment succeeds.
The most reliable workaround I found was to reinstall the metrics. I.E. MODE=reinstall

--- Additional comment from Jeff Cantrill on 2017-04-07 08:15:12 EDT ---

The work around to resolve this issue is:

Determine the number of min masters by:

min_masters = floor("# ES cluster nodes" / 2) + 1 

1. oc edit dc $ES_DC_NAME
2. add env entry to container with name: 'MIN_MASTERS' value: $min_master
3. oc rollout latest $DC_NAME

Apply change to each deploymentconfig.

Fix for the deployer is forthcoming.

--- Additional comment from Boris Kurktchiev on 2017-04-07 08:59:54 EDT ---

So just tested this and it worked... sorta. Now there is a new error but that may have to go in its own bug?

> SEE ATTACHMENT


Also I want to point out that ES_JAVA_OPTS: '-Dmapper.allow_dots_in_name=true -Xms128M -Xmx2048m' even though INSTANCE_RAM=4GB in the DC

--- Additional comment from Jeff Cantrill on 2017-04-07 11:01:10 EDT ---

The issue is the migrate script was not updated to account for the min master change.  Subsequently you see the reported issue.  The resolution is to remove the 'zen.minimum_master_nodes' setting from the logging-elasticsearch configmap or edit each DC as described in #8.

Comment 1 Jeff Cantrill 2017-04-18 15:50:47 UTC

*** This bug has been marked as a duplicate of bug 1439356 ***