Description: thermald monitors and controls platform temperature. Thermal issues are important to handle proactively to reduce performance impact. thermald uses the existing Linux kernel infrastructure and can be easily enhanced. Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18857946 Issues: No known issues. Rpmlint has some false positive complaints. FAS-User: besser82 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/thermald.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/thermald-1.6-0.1.fc27.src.rpm Thanks for review in advance!
Updated package: Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18858019 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/thermald.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/thermald-1.6-0.2.fc27.src.rpm
Updated package: Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18861986 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/thermald.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/thermald-1.6-0.3.fc27.src.rpm
Looks good so far. There are two or three questions: Shouldn't the versioned Requires only have a single equal-sign ? What about the dbus-files ? The service-file should be under /usr/, but no other package installs the *.conf-file there, they all keep (or install) it under /etc. I did not find anything in the guidelines about that. Shouldn't the service be enabled as default ? And therefore get a preset-file ? I think it might be expected by the normal user to work out of the box with default settings. It should be covered by https://fedoraproject.org/wiki/Packaging:DefaultServices#Locally_running_services . Jens
(In reply to Jens Lody from comment #3) > Looks good so far. > There are two or three questions: > > Shouldn't the versioned Requires only have a single equal-sign ? Well, it works with a single or a double equal-sign (tested from el5 to recent Fedora). I simply prefer the doubled one, because - from perspective of a hacker - it looks more obvious like a comparison than an assignment. > What about the dbus-files ? > The service-file should be under /usr/, but no other package installs the > *.conf-file there, they all keep (or install) it under /etc. I did not find > anything in the guidelines about that. There is nothing noted in the guidelines, but there is a common rule of thumb saying: User editable / customizable config goes in /etc, system-presets go to /usr/share. > Shouldn't the service be enabled as default ? > And therefore get a preset-file ? > I think it might be expected by the normal user to work out of the box with > default settings. > It should be covered by > https://fedoraproject.org/wiki/Packaging: > DefaultServices#Locally_running_services . Just requested a systemd-preset for it: https://bugzilla.redhat.com/show_bug.cgi?id=1440479
Updated package: Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18908688 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/thermald.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/thermald-1.6-0.4.fc27.src.rpm
Package is approved. I personally would like to see it in Fedora, no matter if it has a systemd-preset or not. So feel free to add it and probably add the preset later (if the request will be accepted). Jens
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/thermald
thermald-1.6-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ab248cfca4
thermald-1.6-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9ab3f22a16
thermald-1.6-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a4b9c07b2c
thermald-1.6-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-b883f07f79
thermald-1.6-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9ab3f22a16
thermald-1.6-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a4b9c07b2c
thermald-1.6-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ab248cfca4
thermald-1.6-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-b883f07f79
thermald-1.6-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
thermald-1.6-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
thermald-1.6-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
thermald-1.6-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
*** Bug 974714 has been marked as a duplicate of this bug. ***