Description of problem: I suggest an English review of SSO messages that are surfaced to the login screen. Please see my comment in [1]. Any of these messages that are surfaced to the user should undergo some English review, and we should ensure they match with PatternFly's standard login screen messages. I'm concerned about messages like "no profile found in credentials," which is awkward English and would be confusing to a user. [1] https://gerrit.ovirt.org/#/c/75094/5/backend/manager/modules/enginesso/src/main/resources/AppMessages.properties
(In reply to Greg Sheremeta from comment #0) > Description of problem: > I suggest an English review of SSO messages that are surfaced to the login > screen. > > Please see my comment in [1]. Any of these messages that are surfaced to the > user should undergo some English review, and we should ensure they match > with PatternFly's standard login screen messages. Could you please provide a link?
http://www.patternfly.org/styles/terminology-and-wording/ But I don't see specific login phrases there. Please email Serena Doyle directly. sdoyle (she doesn't use BZ)
Ravi, could you please contact Serena? Anyway let's take a look and discuss if we can make error message more understandable to users ...
Only one of the messages in the patch will be displayed to the user, NO_USER_NAME_IN_CREDENTIALS_INTERACTIVE_AUTH=Please enter a user name. Which already looks good IMO. The others will not occur on user interaction but only during vm logon or restapi invocation.
@Ravi, I didn't follow that. Aren't there others, like 'invalid password', 'your account is locked', etc.?
@Greg, below is the list of all messages displayed by SSO to user AUTHENTICATION_FAILED=Authentication failed. AUTHENTICATION_REQUIRED=Authentication required. CANNOT_AUTHENTICATE_USER=Cannot authenticate user %s. CANNOT_AUTHENTICATE_USER_IN_DOMAIN=Cannot authenticate user '%1$s@%2$s': %3$s. CHANGE_PASSWORD_SUCCEEDED=Change password succeeded, enter new credentials to login. CHANGE_PASSWORD_FAILED=Change Password for user '%1$s' failed : %2$s. INVALID_CREDENTIALS=Invalid credentials. NO_USER_NAME_IN_CREDENTIALS_INTERACTIVE_AUTH=Please enter a user name. PASSWORDS_DONT_MATCH=The passwords don't match. SESSION_EXPIRED=Session expired please try again. USER_PASSWORD_EXPIRED_CHANGE_URL_PROVIDED=Cannot Login. User Password has expired. Use the following URL to change the password: <a href='%s'> Link </a> USER_FAILED_TO_AUTHENTICATE=Login failed. Please verify your login information or contact the system administrator. USER_FAILED_TO_AUTHENTICATE_WRONG_USERNAME_OR_PASSWORD=The user name or password is incorrect. USER_ACCOUNT_DISABLED=Cannot Login. User Account is Disabled or Locked, Please contact your system administrator. USER_ACCOUNT_EXPIRED=Cannot Login. User Account has expired, Please contact your system administrator. USER_PASSWORD_EXPIRED=Cannot Login. User Password has expired, Please change your password. USER_FAILED_TO_AUTHENTICATE_TIMED_OUT=Login failed. A timeout has occurred to one or more of the servers that participate in the login process.
Sorry here is the correct list CHANGE_PASSWORD_SUCCEEDED=Change password succeeded, enter new credentials to login. CHANGE_PASSWORD_FAILED=Change Password for user '%1$s' failed : %2$s. NO_USER_NAME_IN_CREDENTIALS_INTERACTIVE_AUTH=Please enter a user name. PASSWORDS_DONT_MATCH=The passwords don't match. SESSION_EXPIRED=Session expired please try again. USER_PASSWORD_EXPIRED_CHANGE_URL_PROVIDED=Cannot Login. User Password has expired. Use the following URL to change the password: <a href='%s'> Link </a> USER_FAILED_TO_AUTHENTICATE=Login failed. Please verify your login information or contact the system administrator. USER_ACCOUNT_DISABLED=Cannot Login. User Account is Disabled or Locked, Please contact your system administrator. USER_ACCOUNT_EXPIRED=Cannot Login. User Account has expired, Please contact your system administrator. USER_PASSWORD_EXPIRED=Cannot Login. User Password has expired, Please change your password. USER_FAILED_TO_AUTHENTICATE_TIMED_OUT=Login failed. A timeout has occurred to one or more of the servers that participate in the login process.
Verified with: rhevm-4.1.3.1-0.1.el7.noarch