Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1440440

Summary:	English review of SSO messages that are surfaced to the login screen
Product:	[oVirt] ovirt-engine	Reporter:	Greg Sheremeta <gshereme>
Component:	AAA	Assignee:	Ravi Nori <rnori>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Gonza <grafuls>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	future	CC:	bugs, gshereme, mperina, rnori, stirabos
Target Milestone:	ovirt-4.1.3	Flags:	rule-engine: ovirt-4.1+
Target Release:	4.1.3.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-07-06 13:16:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Greg Sheremeta 2017-04-08 23:25:50 UTC

Description of problem:
I suggest an English review of SSO messages that are surfaced to the login screen.

Please see my comment in [1]. Any of these messages that are surfaced to the user should undergo some English review, and we should ensure they match with PatternFly's standard login screen messages. I'm concerned about messages like "no profile found in credentials," which is awkward English and would be confusing to a user.

[1] https://gerrit.ovirt.org/#/c/75094/5/backend/manager/modules/enginesso/src/main/resources/AppMessages.properties

Comment 1 Martin Perina 2017-04-09 15:17:18 UTC

(In reply to Greg Sheremeta from comment #0)
> Description of problem:
> I suggest an English review of SSO messages that are surfaced to the login
> screen.
> 
> Please see my comment in [1]. Any of these messages that are surfaced to the
> user should undergo some English review, and we should ensure they match
> with PatternFly's standard login screen messages.

Could you please provide a link?

Comment 2 Greg Sheremeta 2017-04-09 15:36:55 UTC

http://www.patternfly.org/styles/terminology-and-wording/

But I don't see specific login phrases there. Please email Serena Doyle directly. sdoyle (she doesn't use BZ)

Comment 3 Martin Perina 2017-04-14 19:19:05 UTC

Ravi, could you please contact Serena? Anyway let's take a look and discuss if we can make error message more understandable to users ...

Comment 4 Ravi Nori 2017-04-17 13:41:07 UTC

Only one of the messages in the patch will be displayed to the user, NO_USER_NAME_IN_CREDENTIALS_INTERACTIVE_AUTH=Please enter a user name. Which already looks good IMO. The others will not occur on user interaction but only during vm logon or restapi invocation.

Comment 5 Greg Sheremeta 2017-04-17 20:34:51 UTC

@Ravi, I didn't follow that. Aren't there others, like 'invalid password', 'your account is locked', etc.?

Comment 6 Ravi Nori 2017-04-18 12:48:27 UTC

@Greg, below is the list of all messages displayed by SSO to user

AUTHENTICATION_FAILED=Authentication failed.
AUTHENTICATION_REQUIRED=Authentication required.
CANNOT_AUTHENTICATE_USER=Cannot authenticate user %s.
CANNOT_AUTHENTICATE_USER_IN_DOMAIN=Cannot authenticate user '%1$s@%2$s': %3$s.
CHANGE_PASSWORD_SUCCEEDED=Change password succeeded, enter new credentials to login.
CHANGE_PASSWORD_FAILED=Change Password for user '%1$s' failed : %2$s.
INVALID_CREDENTIALS=Invalid credentials.
NO_USER_NAME_IN_CREDENTIALS_INTERACTIVE_AUTH=Please enter a user name.
PASSWORDS_DONT_MATCH=The passwords don't match.
SESSION_EXPIRED=Session expired please try again.
USER_PASSWORD_EXPIRED_CHANGE_URL_PROVIDED=Cannot Login. User Password has expired. Use the following URL to change the password: <a href='%s'> Link </a>
USER_FAILED_TO_AUTHENTICATE=Login failed. Please verify your login information or contact the system administrator.
USER_FAILED_TO_AUTHENTICATE_WRONG_USERNAME_OR_PASSWORD=The user name or password is incorrect.
USER_ACCOUNT_DISABLED=Cannot Login. User Account is Disabled or Locked, Please contact your system administrator.
USER_ACCOUNT_EXPIRED=Cannot Login. User Account has expired, Please contact your system administrator.
USER_PASSWORD_EXPIRED=Cannot Login. User Password has expired, Please change your password.
USER_FAILED_TO_AUTHENTICATE_TIMED_OUT=Login failed. A timeout has occurred to one or more of the servers that participate in the login process.

Comment 7 Ravi Nori 2017-04-18 13:00:47 UTC

Sorry here is the correct list

CHANGE_PASSWORD_SUCCEEDED=Change password succeeded, enter new credentials to login.
CHANGE_PASSWORD_FAILED=Change Password for user '%1$s' failed : %2$s.
NO_USER_NAME_IN_CREDENTIALS_INTERACTIVE_AUTH=Please enter a user name.
PASSWORDS_DONT_MATCH=The passwords don't match.
SESSION_EXPIRED=Session expired please try again.
USER_PASSWORD_EXPIRED_CHANGE_URL_PROVIDED=Cannot Login. User Password has expired. Use the following URL to change the password: <a href='%s'> Link </a>
USER_FAILED_TO_AUTHENTICATE=Login failed. Please verify your login information or contact the system administrator.
USER_ACCOUNT_DISABLED=Cannot Login. User Account is Disabled or Locked, Please contact your system administrator.
USER_ACCOUNT_EXPIRED=Cannot Login. User Account has expired, Please contact your system administrator.
USER_PASSWORD_EXPIRED=Cannot Login. User Password has expired, Please change your password.
USER_FAILED_TO_AUTHENTICATE_TIMED_OUT=Login failed. A timeout has occurred to one or more of the servers that participate in the login process.

Comment 8 Gonza 2017-06-06 08:07:34 UTC

Verified with:
rhevm-4.1.3.1-0.1.el7.noarch