Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/c72578/cpprest/cpprest.git/diff/cpprest.spec?h=f25 SRPM URL: https://copr-be.cloud.fedoraproject.org/results/c72578/cpprest/fedora-25-x86_64/00536482-cpprest/ copr: https://copr.fedorainfracloud.org/coprs/c72578/cpprest/ Description: The C++ REST SDK is a Microsoft project for cloud-based client-server communication in native code using a modern asynchronous C++ API design. This project aims to help C++ developers connect to and interact with services. Fedora Account System Username: c72578
- This is my first package and I would need a sponsor. - Link to successful Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18795939
Motivation for packaging: cpprest (C++REST SDK) is a requirement for Poedit, in order to enable Crowdin integration.
The Fedora Project does a couple of packaging related things differently than whatever distribution you've used before. Here's the result of a brief look at the spec file. Consider pointing the fedora-review tool at this ticket: fedora-review -b 1440704 It will evaluate the latest "Spec URL:" and "SRPM URL:" lines, download the files and packages, perform local test-builds in Mock and run many checks on the packages. The tool is relevant to package submitters, too. > Patch0: cpprest-pthread.patch https://fedoraproject.org/wiki/Packaging:Guidelines#Patch_Guidelines > %package devel > Summary: Development files for %{name} > Requires: libcpprest%{major}_%{minor} = %{version} https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > %files -n libcpprest%{major}_%{minor} > %defattr(-,root,root) > %doc CONTRIBUTORS.txt license.txt ThirdPartyNotices.txt > %{_libdir}/libcpprest.so.%{major}.%{minor} > %{_libdir}/libcpprest.so https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages > %defattr(-,root,root) https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions > %package -n libcpprest%{major}_%{minor} The naming of this subpackage is odd. What have you planned for updates that touch %major or %minor or both?
Spec URL: https://gist.githubusercontent.com/c72578/8902da86b1987d6ecd7c1e6741082c02/raw SRPM URL: https://copr-be.cloud.fedoraproject.org/results/c72578/cpprest/fedora-25-x86_64/00543603-cpprest/cpprest-2.9.1-2.fc25.src.rpm Dear Michael, thank you very much for your valuable feedback. The spec file has been updated according to your comments. Changes, diff to spec file: http://copr-dist-git.fedorainfracloud.org/cgit/c72578/cpprest/cpprest.git/commit/cpprest.spec?h=f25&id=3b1758bf36ebfc19c391e8632bff6c6dae37aabe
Spec URL: https://raw.githubusercontent.com/c72578/rpmbuild/master/SPECS/cpprest.spec
Spec URL: https://raw.githubusercontent.com/c72578/rpmbuild/master/SPECS/cpprest.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/c72578/cpprest/fedora-25-x86_64/00544736-cpprest/cpprest-2.9.1-3.fc25.src.rpm Some Updates to the spec file in the meantime: * Fri Apr 28 2017 Wolfgang Stöggl <c72578> - 2.9.1-3 - Updated spec file - Changed Source0 filename from v2.9.1.tar.gz to cpprest-2.9.1.tar.gz - Convert ThirdPartyNotices.txt to utf-8 Changes, diff to spec file: https://github.com/c72578/rpmbuild/commit/dc36843ccedfa67818662c152fd647919ccf0690
Spec URL: https://raw.githubusercontent.com/c72578/rpmbuild/master/SPECS/cpprest.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/c72578/cpprest/fedora-25-x86_64/00544987-cpprest/cpprest-2.9.1-4.fc25.src.rpm Further updates to the spec file and modifications in order to fix warnings and errors reported by rpmlint: * Sat Apr 29 2017 Wolfgang Stöggl <c72578> - 2.9.1-4 - Updated spec file - Remove spurious-executable-perm earlier in spec file (after setup) - Change end-of-line encoding of two files to Unix (LF) Changes to spec file: https://github.com/c72578/rpmbuild/commits/master/SPECS/cpprest.spec
Spec URL: https://raw.githubusercontent.com/c72578/rpmbuild/master/SPECS/cpprest.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/c72578/cpprest/fedora-25-x86_64/00544987-cpprest/cpprest-2.9.1-4.fc25.src.rpm
Spec URL: https://raw.githubusercontent.com/c72578/rpmbuild/master/SPECS/cpprest.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/c72578/cpprest/fedora-25-x86_64/00545331-cpprest/cpprest-2.9.1-5.fc25.src.rpm Further update to the spec file * Sun Apr 30 2017 Wolfgang Stöggl <c72578> - 2.9.1-5 - Fix unused-direct-shlib-dependency reported by rpmlint (installed packages) - Link to latest successful Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19324094
Spec URL: https://raw.githubusercontent.com/c72578/rpmbuild/master/SPECS/cpprest.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/c72578/cpprest/fedora-25-x86_64/00547362-cpprest/cpprest-2.9.1-6.fc25.src.rpm * Fri May 05 2017 Wolfgang Stöggl <c72578> - 2.9.1-6 - Use directory build.release for cmake
Spec URL: https://raw.githubusercontent.com/c72578/rpmbuild/master/SPECS/cpprest.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/c72578/cpprest/fedora-25-x86_64/00549481-cpprest/cpprest-2.9.1-7.fc25.src.rpm * Tue May 09 2017 Wolfgang Stöggl <c72578> - 2.9.1-7 - Add requirement websocketpp-devel. Build against the Fedora websocketpp package and not the embedded version of cpprest. - Add -DCMAKE_INCLUDE_PATH=/usr/share/cmake/websocketpp/ so that websocketpp is found - Add patch cpprest-Fix-build-issue-with-openssl-1.1-From-Kurt-Roeckx
Spec URL: https://raw.githubusercontent.com/c72578/rpmbuild/master/SPECS/cpprest.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/c72578/cpprest/fedora-rawhide-x86_64/00556075-cpprest/cpprest-2.9.1-10.fc27.src.rpm * Wed May 24 2017 Wolfgang Stöggl <c72578> - 2.9.1-10 - Apply cpprest-2.9.1-openssl-1.1.patch anyway, remove the condition fedora > 25, which is not needed * Tue May 23 2017 Wolfgang Stöggl <c72578> - 2.9.1-9 - Rebuild using websocketpp-0.7.0-5.fc26 for F26 and rawhide - Rename patch file including version of cpprest - Set license to MIT. This is the license of C++ REST SDK (license.txt). Websocket++ is a separate Fedora package (websocketpp-devel) and its license is handled there. - Use BuildRequires: pkgconfig(openssl) instead of openssl-devel * Thu May 18 2017 Wolfgang Stöggl <c72578> - 2.9.1-8 - Rebuild for testing websocketpp-0.7.0-4.fc26
Spec URL: https://raw.githubusercontent.com/c72578/rpmbuild/master/SPECS/cpprest.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/c72578/cpprest/fedora-rawhide-x86_64/00557914-cpprest/cpprest-2.9.1-11.fc27.src.rpm * Mon May 29 2017 Wolfgang Stöggl <c72578> - 2.9.1-11 - Explicitly require openssl-devel instead of pkgconfig(openssl), so we build against OpenSSL 1.1 on F26 and rawhide and not compat-openssl10.
Spec URL: https://raw.githubusercontent.com/c72578/rpmbuild/master/SPECS/cpprest.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/c72578/cpprest/fedora-rawhide-x86_64/00562301-cpprest/cpprest-2.9.1-12.fc27.src.rpm Update cpprest.spec file - 2.9.1-12 * Wed Jun 07 2017 Wolfgang Stöggl <c72578> - 2.9.1-12 - Removed BR: gcc-c++ - Added check section and tests - Add patch to disable outside/failing tests
Spec URL: https://raw.githubusercontent.com/c72578/rpmbuild/master/SPECS/cpprest.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/c72578/cpprest/fedora-rawhide-x86_64/00562467-cpprest/cpprest-2.9.1-13.fc27.src.rpm Update cpprest.spec file - 2.9.1-13 * Wed Jun 07 2017 Wolfgang Stöggl <c72578> - 2.9.1-13 - Add patch to disable tests with long timeouts, which fail in mock build
I see in FAS you're already sponsored as a packager, no need any more to block the tracker.
Taking this review.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Ms-PL", "Apache (v2.0)", "Unknown or generated", "MIT/X11 (BSD like)", "zlib/libpng", "BSD (3 clause)". 714 files have unknown license. Detailed output of licensecheck in /home/makerpm/1440704-cpprest/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cpprest- debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define major 2, %define minor 9 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cpprest-2.9.1-13.fc27.x86_64.rpm cpprest-devel-2.9.1-13.fc27.x86_64.rpm cpprest-debuginfo-2.9.1-13.fc27.x86_64.rpm cpprest-2.9.1-13.fc27.src.rpm cpprest.x86_64: W: hidden-file-or-dir /usr/lib/.build-id cpprest.x86_64: W: hidden-file-or-dir /usr/lib/.build-id cpprest-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (debuginfo) ------------------- Checking: cpprest-debuginfo-2.9.1-13.fc27.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory cpprest-devel.x86_64: W: only-non-binary-in-usr-lib cpprest.x86_64: W: hidden-file-or-dir /usr/lib/.build-id cpprest.x86_64: W: hidden-file-or-dir /usr/lib/.build-id 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Requires -------- cpprest-debuginfo (rpmlib, GLIBC filtered): cpprest-devel (rpmlib, GLIBC filtered): cpprest(x86-64) libcpprest.so.2.9()(64bit) cpprest (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libboost_system.so.1.63.0()(64bit) libboost_thread.so.1.63.0()(64bit) libc.so.6()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libpthread.so.0()(64bit) libssl.so.1.1()(64bit) libssl.so.1.1(OPENSSL_1_1_0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) rtld(GNU_HASH) Provides -------- cpprest-debuginfo: cpprest-debuginfo cpprest-debuginfo(x86-64) cpprest-devel: cpprest-devel cpprest-devel(x86-64) cpprest: cpprest cpprest(x86-64) libcpprest.so.2.9()(64bit) Source checksums ---------------- https://github.com/Microsoft/cpprestsdk/archive/v2.9.1.tar.gz#/cpprest-2.9.1.tar.gz : CHECKSUM(SHA256) this package : 7097889965df48ec5799d6ed3b4f95f16ca82ee3512eb31db844d9df600bc899 CHECKSUM(SHA256) upstream package : 7097889965df48ec5799d6ed3b4f95f16ca82ee3512eb31db844d9df600bc899 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/bin/fedora-review -b 1440704 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package looks good. PACKAGE APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/cpprest
cpprest-2.9.1-13.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b263af9167
cpprest-2.9.1-13.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b263af9167
cpprest-2.9.1-16.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e5926e9706
cpprest-2.9.1-16.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e5926e9706
cpprest-2.9.1-13.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
cpprest-2.9.1-16.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.