Bug 1440805 - Update rfc.sh to check Change-Id consistency for backports
Summary: Update rfc.sh to check Change-Id consistency for backports
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: scripts
Version: 3.10
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Shyamsundar
QA Contact:
URL:
Whiteboard:
Depends On: 1428047
Blocks: glusterfs-3.10.2
TreeView+ depends on / blocked
 
Reported: 2017-04-10 14:01 UTC by Shyamsundar
Modified: 2017-05-31 20:46 UTC (History)
5 users (show)

Fixed In Version: glusterfs-3.10.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1428047
Environment:
Last Closed: 2017-05-31 20:46:29 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Shyamsundar 2017-04-10 14:01:24 UTC
+++ This bug was initially created as a clone of Bug #1428047 +++

--- Additional comment from Worker Ant on 2017-04-05 16:53:12 EDT ---

REVIEW: https://review.gluster.org/17004 (scripts: Update rfc.sh to check existance of Change-Id in backports) posted (#1) for review on master by Shyamsundar Ranganathan (srangana)

--- Additional comment from Shyamsundar on 2017-04-05 16:58:39 EDT ---

The initial change to enforce/remind contributors to this requirement is to update rfc.sh. The commit in comment #2 is towards the same.

-----------------------

Cloning the rfc.sh changes part as a bug for 3.10.

Comment 1 Worker Ant 2017-04-10 14:04:53 UTC
REVIEW: https://review.gluster.org/17030 (scripts: Update rfc.sh to check existance of Change-Id in backports) posted (#1) for review on release-3.10 by Shyamsundar Ranganathan (srangana)

Comment 2 Worker Ant 2017-04-10 18:59:33 UTC
COMMIT: https://review.gluster.org/17030 committed in release-3.10 by Shyamsundar Ranganathan (srangana) 
------
commit 226c841bad19d0348acba22808cc65853c2b15ea
Author: Shyam <srangana>
Date:   Wed Apr 5 14:22:57 2017 -0400

    scripts: Update rfc.sh to check existance of Change-Id in backports
    
    Addition to this script is a no-op on master.
    
    This would need to be backported to active release branches to be
    effective.
    
    This check is not smart proof, in that someone could proceed knowing
    that the Change-Id differs from master, but this is not expected to
    catch that, instead it is to serve more as a reminder that we need
    the same Change-Id across branches.
    
    Contributors not using rfc.sh would not see this, but they are few
    and possibly far in between. Also contributors using gerrit to
    cherry-pick changes will not see this. For both cases a server side
    solution to catch any changes are needed.
    
    There is a possiblilty that we will follow this up with a check
    on the gerrit end and add a comment to the reviews, to aid reviewers
    to quickly check the sanity of the Change-Id when it differs.
    
    > BUG: 1428047
    > Signed-off-by: Shyam <srangana>
    > Reviewed-on: https://review.gluster.org/17004
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: Niels de Vos <ndevos>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle>
    > Reviewed-by: Amar Tumballi <amarts>
    
    Change-Id: I11e371489a4a3cf2ff96d9892256986cd535998b
    BUG: 1440805
    Signed-off-by: Shyam <srangana>
    Reviewed-on: https://review.gluster.org/17030
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Raghavendra Talur 2017-05-31 20:46:29 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.2, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.