Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1440823

Summary: OSP 10 backport - No comments in nova.conf in the overcloud.
Product: Red Hat OpenStack Reporter: Andreas Karis <akaris>
Component: rhosp-director-imagesAssignee: Rajesh Tailor <ratailor>
Status: CLOSED CURRENTRELEASE QA Contact: Omri Hochman <ohochman>
Severity: medium Docs Contact:
Priority: medium    
Version: 10.0 (Newton)CC: dcadzow, emacchi, fj-lsoft-bm, fj-lsoft-ofuku, hmatsumo, jschluet, lyarwood, mwitt, ohochman, ratailor, tumeya, vcojot, ykawada
Target Milestone: z13Keywords: FeatureBackport, OtherQA, TestOnly, Triaged, ZStream
Target Release: 10.0 (Newton)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: QJ170210-022
Fixed In Version: openstack-tripleo-puppet-elements-5.3.3-4.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1427078 Environment:
Last Closed: 2019-12-18 10:22:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1427078    
Bug Blocks:    

Description Andreas Karis 2017-04-10 14:29:42 UTC 
Hi,

This was fixed in OSP 11, but we also need a backport for OSP 10 as this is our long term support version.

Thanks,

Andreas

+++ This bug was initially created as a clone of Bug #1427078 +++

Description of Problem:
    In the RHOSP10 overcloud nodes, nova.conf contains no comment lines.

    In the Director's deployment process, nova.conf is removed by the
    following script and recreated by Puppet. So the comments in the
    original nova.conf file are deleted.

        /usr/libexec/os-refresh-config/configure.d/40-truncate-nova-config

    This script was added as a workaround for the following bug.

        https://bugs.launchpad.net/oslo.config/+bug/1568820

    But we think this bug has been already fixed in RHOSP10, so this
    workaround is meaningless, but the script still exists in the image.

    It is sometimes inconvenient that there are no comments in the nova.conf,
    especially when troubleshooting issues.
    Note that this issue exists only in nova.conf and other configuration
    files contain comment lines.

    So please fix this bug.

Version-Release number of selected component:

  Red Hat Enterprise Linux OpenStack Platform Version Number: 10
  Release Number: GA
  Related Package Version:
                    rhosp-director-images-10.0-20161212.1.el7ost.noarch
  Related Middleware/Application:
                    openstack-tripleo-heat-templates-5.1.0-7.el7ost.noarch
  Underlying RHEL Release Number:   7.3
  Underlying RHEL Architecture:     x86_64
  Underlying RHEL Kernel Version:   3.10.0-514.2.2.el7.x86_64

Drivers or hardware or architecture dependency:
  None

How reproducible:
  Always

Step to Reproduce:
  Deploy the overcloud from the RHOSP10 Director.

Actual Results:
  nova.conf has no comment lines.

Expected Results:
  nova.conf keeps its original comment lines.

Summary of actions taken to resolve issue:
  None

Location of diagnostic data:
  None

Hardware configuration:

  Model:
  CPU Info:
  Memory Info:
  Hardware Component Information:
  Configuration Info:
  Guest Configuration Info:

> Target Release: RHOSP 11

Good news!

It looks like this has already been fixed in OSP11. 

I was also able to confirm that the comments were indeed missing from nova.conf in OPS10.

And I've submitted a cleanup patch that removes the now-unused workaround you mentioned.

    https://review.openstack.org/#/c/442611/

This area was new to me – thanks for the detailed bug description; it was really helpful pointing me in the right direction.
Comment 1 Red Hat Bugzilla Rules Engine 2017-04-10 14:29:56 UTC 
This bugzilla has been removed from the release and needs to be reviewed and Triaged for another Target Release.
Comment 2 Red Hat Bugzilla Rules Engine 2017-04-10 14:31:04 UTC 
This bugzilla has been removed from the release and needs to be reviewed and Triaged for another Target Release.
Comment 3 Red Hat Bugzilla Rules Engine 2017-04-10 14:38:04 UTC 
This bugzilla has been removed from the release and needs to be reviewed and Triaged for another Target Release.
Comment 4 ykawada 2017-04-10 23:21:32 UTC 
Yo Kawada will monitor this ticket as TAM.
Comment 5 melanie witt 2017-12-01 15:31:03 UTC 
It looks like this was fixed upstream as of ocata (OSP 11) by the combination of a oslo.config patch [1] and an unspecified change in tripleo-puppet-elements.

There was a cleanup patch mentioned in the OSP 11 version of this BZ (bug 1427078) whose commit message states that it removed a workaround that was causing comments to be stripped from nova.conf. The workaround was intended to deal with an oslo.config problem fixed by [1].

The oslo.config fix [1] is included in oslo.config 3.17.1, which is what we're shipping with OSP 10:

$ brew list-tagged rhos-10.0-rhel-7 python-oslo-config --latest
Build                                     Tag                   Built by
----------------------------------------  --------------------  ----------------
python-oslo-config-3.17.1-1.el7ost        rhos-10.0-rhel-7      jschluet

So it seems to me that what we need for OSP 10 is to backport [2] to tripleo-puppet-elements for OSP 10, since we should have the oslo.config fix available already and the workaround that strips comments from nova.conf should no longer be needed.

[1] https://review.openstack.org/#/c/304802
[2] https://review.openstack.org/#/c/442611
Comment 6 Lon Hohberger 2018-09-18 10:36:53 UTC 
According to our records, this should be resolved by openstack-tripleo-puppet-elements-5.3.3-4.el7ost.  This build is available now.