Spec URL: https://athoscr.fedorapeople.org/packaging/python-booleanOperations.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/python-booleanOperations-0.7.0-1.fc25.src.rpm Description: Boolean operations on paths based on a super fast polygon clipper library by Angus Johnson. Fedora Account System Username: athoscr
This is not a formal review. I did not have any chance to test this out, but the tests pass. Fedora tends not to use upper case in its package names, though without a delimiter between the words, changing it might not be a good choice. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 15 files have unknown license. Detailed output of licensecheck in 1440992-python-booleanOperations/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.6/site- packages, /usr/lib/python3.6 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [?]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-booleanOperations , python3-booleanOperations [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-booleanOperations-0.7.0-1.fc27.noarch.rpm python3-booleanOperations-0.7.0-1.fc27.noarch.rpm python-booleanOperations-0.7.0-1.fc27.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- python2-booleanOperations (rpmlib, GLIBC filtered): python(abi) python2-fonttools python2-pyclipper python2-ufolib python3-booleanOperations (rpmlib, GLIBC filtered): python(abi) python3-fonttools python3-pyclipper python3-ufolib Provides -------- python2-booleanOperations: python-booleanOperations python2-booleanOperations python2.7dist(booleanoperations) python2dist(booleanoperations) python3-booleanOperations: python3-booleanOperations python3.6dist(booleanoperations) python3dist(booleanoperations) Source checksums ---------------- https://github.com/typemytype/booleanOperations/archive/0.7.0/booleanOperations-0.7.0.tar.gz : CHECKSUM(SHA256) this package : 067400bd8f5a677013a62115687ab89c80979773ac16155f755d98a35db544b1 CHECKSUM(SHA256) upstream package : 067400bd8f5a677013a62115687ab89c80979773ac16155f755d98a35db544b1 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1440992 -L pyclipper Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Built with local dependencies: pyclipper/python2-setuptools_scm_git_archive-1.0-1.fc27.noarch.rpm pyclipper/python3-pyclipper-1.0.6-1.fc27.x86_64.rpm pyclipper/python-pyclipper-debuginfo-1.0.6-1.fc27.x86_64.rpm pyclipper/python3-setuptools_scm_git_archive-1.0-1.fc27.noarch.rpm pyclipper/python2-pyclipper-1.0.6-1.fc27.x86_64.rpm
If you keep the camelCased name, please add %python_provide with the lowercased names too (python2-booleanoperations and python3-booleanoperations). QuLogic, I assigned the review to you because it seems you have already done most of the work for this one. If you don't want to take it, assign it back to me.
Changed the package name and updated version Spec URL: https://athoscr.fedorapeople.org/packaging/python-booleanoperations.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/python-booleanoperations-0.7.1-1.fc26.src.rpm
Any help here to move the review though process?
Yes. As per BZ#1440971, polyclipping is embedded in one of the dependencies. We need should help upstream updating the bindings to the latest polyclipping library. Help doing that is much appreciated.
No more blockers on the way, so I am updating the package so we can go on with the review: Spec URL: https://athoscr.fedorapeople.org/packaging/python-booleanoperations.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/python-booleanoperations-0.8.0-1.fc27.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25103198
consider using the macro %{python3_pkgversion} even if you don't have plans to build for epel right now
I notice that https://github.com/typemytype/booleanOperations/blob/master/README.rst states: > Boolean operations on paths based on a super fast polygon clipper library by Angus Johnson However, this Clipper library is released under the Boost Software License, not the MIT licence which BooleanOperations claims. The Boost Software License require that this licence is preserved in derivatives. I have raised https://github.com/typemytype/booleanOperations/issues/47 upstream, asking them to clarify the situation.
(In reply to Peter Oliver from comment #9) > I notice that > https://github.com/typemytype/booleanOperations/blob/master/README.rst > states: > > > Boolean operations on paths based on a super fast polygon clipper library by Angus Johnson > > However, this Clipper library is released under the Boost Software License, > not the MIT licence which BooleanOperations claims. The Boost Software > License require that this licence is preserved in derivatives. > > I have raised https://github.com/typemytype/booleanOperations/issues/47 > upstream, asking them to clarify the situation. BooleanOperations is not a derivative work of pyclipper. It is not a derivative of the clipper library as well and pyclipper itself is not a derivative work of the clipper library. - pyclipper is a set of python bindings for the clipper library (this is not a derivative, it just uses the library). - BooleanOperations is a python package that uses (imports) pyclipper, which does not mean it is a derivative as well. Derivative works would be modifications on top of the software in question. Just to be sure, I am rasing Fedora legal flag.
Upstream have confirmed that "based on" here means "uses as a library", so nothing to worry about.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-booleanoperations , python3-booleanoperations [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-booleanoperations-0.8.0-1.fc28.noarch.rpm python3-booleanoperations-0.8.0-1.fc28.noarch.rpm python-booleanoperations-0.8.0-1.fc28.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- python2-booleanoperations.noarch: W: invalid-url URL: https://pypi.org/project/booleanOperations <urlopen error [Errno -2] Name or service not known> python3-booleanoperations.noarch: W: invalid-url URL: https://pypi.org/project/booleanOperations <urlopen error [Errno -2] Name or service not known> 2 packages and 0 specfiles checked; 0 errors, 2 warnings.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-booleanoperations