Spec URL: https://luya.fedorapeople.org/packages/SPECS/swatchbooker.spec SRPM URL: https://luya.fedorapeople.org/packages/SRPMS/swatchbooker-0.7.6-1.fc25.src.rpm Description: Color swatch editor Fedora Account System Username: luya
Scratch build result: https://koji.fedoraproject.org/koji/taskinfo?taskID=18920004
Hi, /usr/lib/%{name}/* should be changed into %{_prefix}/lib/%{name}/* I suppose.
Updated spec and srpm files using latest git snapshot Spec URL: https://luya.fedorapeople.org/packages/SPECS/swatchbooker.spec SRPM URL: https://luya.fedorapeople.org/packages/SRPMS/swatchbooker-0.8-0.1.20170131git.fc25.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in swatchbooker See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/swatchbooker [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/swatchbooker [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [-]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in swatchbooker [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: swatchbooker-0.8-0.1.20170131git.fc25.noarch.rpm swatchbooker-0.8-0.1.20170131git.fc25.src.rpm swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ral_bcs.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/ral_bcs.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_acb.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_acb.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/xara_jcw.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/xara_jcw.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/html.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/html.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/colorschemer.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/colorschemer.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/scribus.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/scribus.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/__init__.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/__init__.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/websvc/__init__.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/websvc/__init__.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_sog.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_sog.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/corel_cpl.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/corel_cpl.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/__init__.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/__init__.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/gimp_ggr.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/gimp_ggr.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_sob.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_sob.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/swatchbooker/swatchbooker.pyw /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_grd.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_grd.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_aco.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_aco.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/swatchbooker/sbconvertor.pyw /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_soc.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_soc.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/color.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/color.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/swatchbooker/sbconvert.py /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/websvc/pantone.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/websvc/pantone.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/quark_qcl.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/quark_qcl.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/gimp_gpl.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/gimp_gpl.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/websvc/dtpstudio.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/websvc/dtpstudio.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_clr.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_clr.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/autocad_acb.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/autocad_acb.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/sbz.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/sbz.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_bcf.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_bcf.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_ase.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_ase.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/gimp_pat_PIL.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/gimp_pat_PIL.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/icc.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/icc.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/riff_pal.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/riff_pal.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/websvc/munsell.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/websvc/munsell.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_pat.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_pat.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_acf.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_acf.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/swatchbooker/sbcommon.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/swatchbooker/sbcommon.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/viva_xml.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/viva_xml.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/corel_xml.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/corel_xml.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/icc_nmcl.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/icc_nmcl.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_act.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_act.py 644 /usr/bin/env python swatchbooker.noarch: W: no-manual-page-for-binary swatchbooker swatchbooker.noarch: W: no-manual-page-for-binary sbconvertor swatchbooker.noarch: W: no-manual-page-for-binary sbconvert swatchbooker.src:90: E: hardcoded-library-path in %{_prefix}/lib/%{name}/* swatchbooker.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 1) 2 packages and 0 specfiles checked; 78 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/swatchbooker/sbconvertor.pyw /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/swatchbooker/sbcommon.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/swatchbooker/sbcommon.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_clr.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_clr.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/__init__.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/__init__.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/icc.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/icc.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_pat.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_pat.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/viva_xml.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/viva_xml.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/websvc/dtpstudio.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/websvc/dtpstudio.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/gimp_ggr.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/gimp_ggr.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/quark_qcl.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/quark_qcl.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/gimp_gpl.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/gimp_gpl.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/xara_jcw.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/xara_jcw.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/autocad_acb.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/autocad_acb.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_bcf.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_bcf.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/__init__.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/__init__.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_ase.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_ase.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/websvc/__init__.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/websvc/__init__.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_sog.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_sog.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/corel_xml.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/corel_xml.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_acb.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_acb.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_grd.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_grd.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/gimp_pat_PIL.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/gimp_pat_PIL.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/websvc/pantone.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/websvc/pantone.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_soc.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_soc.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_aco.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_aco.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/color.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/color.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/corel_cpl.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/corel_cpl.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/scribus.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/scribus.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/swatchbooker/sbconvert.py /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_acf.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_acf.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/colorschemer.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/colorschemer.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_sob.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_sob.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/icc_nmcl.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/icc_nmcl.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/swatchbooker/swatchbooker.pyw /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ral_bcs.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/ral_bcs.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/riff_pal.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/riff_pal.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_act.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/adobe_act.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/sbz.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/sbz.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/html.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/html.py 644 /usr/bin/env python swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/websvc/munsell.py /usr/bin/env python swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/websvc/munsell.py 644 /usr/bin/env python swatchbooker.noarch: W: no-manual-page-for-binary swatchbooker swatchbooker.noarch: W: no-manual-page-for-binary sbconvertor swatchbooker.noarch: W: no-manual-page-for-binary sbconvert 1 packages and 0 specfiles checked; 77 errors, 3 warnings. Requires -------- swatchbooker (rpmlib, GLIBC filtered): /bin/sh /usr/bin/env python(abi) Provides -------- swatchbooker: application() application(sbconvertor.desktop) application(swatchbooker.desktop) mimehandler(application/swatchbook) python2.7dist(swatchbooker) python2dist(swatchbooker) swatchbooker Source checksums ---------------- https://github.com/olivierberten/swatchbooker/archive/c5c8b021c8f9420c26c11372c95a4a6f440dcc97.tar.gz#/SwatchBooker-c5c8b02.tar.gz : CHECKSUM(SHA256) this package : b903221e267df42600b6f5494f9c94e183816e79cd0ea478e8d262469d0900a0 CHECKSUM(SHA256) upstream package : b903221e267df42600b6f5494f9c94e183816e79cd0ea478e8d262469d0900a0 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1441046 Buildroot used: fedora-25-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
> [!]: Package requires other packages for directories it uses. > Note: No known owner of /usr/lib/swatchbooker > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/lib/swatchbooker > swatchbooker.src:90: E: hardcoded-library-path in %{_prefix}/lib/%{name}/* The Python resource files should not be in /usr/lib/swatchbooker, but in /usr/share/swatchbooker. So, for the first error you could use the following in the %files section: %dir %{_prefix}/lib/%{name} %{_prefix}/lib/%{name}/*.py* or %{_prefix}/lib/%{name} But you need to make sure that the python files are placed in /usr/share/swatchbooker and that the %files section just selects that: %{_datadir}/%{name} > swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ral_bcs.py /usr/bin/env python Please fix. You can find an example here: http://pkgs.fedoraproject.org/cgit/rpms/python-rfc3987.git/tree/python-rfc3987.spec#n55 > %global commit c5c8b021c8f9420c26c11372c95a4a6f440dcc97 > %global shortcommit %(c=%{commit}; echo ${c:0:7}) > %global date 20170131 > Release: 0.1%{?date:.%{date}git}%{?dist} This does not express the short git commit in the release field: https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots Please also use commit0/shortcommit0. For example: %global commit0 c5c8b021c8f9420c26c11372c95a4a6f440dcc97 %global shortcommit0 %(c=%{commit0}; echo ${c:0:7}) %global date 20170131 Release: 0.1%{?shortcommit0:.%{date}git%{shortcommit0}}%{?dist} You can also check with %{?date} though, like you did. Optional: 1) Sort BuildRequires, one per line 2) Have you considered building for both Python 2 and 3 in the same SPEC file if supported by upstream? You can still find an example in the same SPEC file above and in the packaging guidelines URL: http://pkgs.fedoraproject.org/cgit/rpms/python-rfc3987.git/tree/python-rfc3987.spec https://fedoraproject.org/wiki/Packaging:Python If you don't, please consider using unversioned python macros, so if the default python interpreter changes the spec files remain valid.
> swatchbooker.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/swatchbook/codecs/html.py 644 /usr/bin/env python Sorry, also this, make sure all .py files are 755.
(In reply to Simone Caronni from comment #5) > > [!]: Package requires other packages for directories it uses. > > Note: No known owner of /usr/lib/swatchbooker > > [!]: Package must own all directories that it creates. > > Note: Directories without known owners: /usr/lib/swatchbooker > > > swatchbooker.src:90: E: hardcoded-library-path in %{_prefix}/lib/%{name}/* > ...(snip)... > But you need to make sure that the python files are placed in > /usr/share/swatchbooker and that the %files section just selects that: > > %{_datadir}/%{name} Done > > > swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ral_bcs.py /usr/bin/env python > > Please fix. You can find an example here: > > http://pkgs.fedoraproject.org/cgit/rpms/python-rfc3987.git/tree/python- > rfc3987.spec#n55 Looking at the tip part: https://fedoraproject.org/wiki/Packaging_tricks?rd=PackageMaintainers/Packaging_Tricks#Remove_shebang_from_Python_libraries How to properly substitute "/usr/bin/env python" with "!/usr/bin/python"? I currently use # Remove shebang for lib in %{buildroot}%{python_sitelib}/swatchbook/*/*.py; do sed '1{\@^#!/usr/bin/env python@d}' $lib > $lib.new && touch -r $lib $lib.new && mv $lib.new $lib done but rpmlint keeps on complaining swatchbooker.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_soc.py > > > %global commit c5c8b021c8f9420c26c11372c95a4a6f440dcc97 > > %global shortcommit %(c=%{commit}; echo ${c:0:7}) > > %global date 20170131 > > Release: 0.1%{?date:.%{date}git}%{?dist} > > This does not express the short git commit in the release field: > > https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots > > Please also use commit0/shortcommit0. For example: > > %global commit0 c5c8b021c8f9420c26c11372c95a4a6f440dcc97 > %global shortcommit0 %(c=%{commit0}; echo ${c:0:7}) > %global date 20170131 > Release: 0.1%{?shortcommit0:.%{date}git%{shortcommit0}}%{?dist} > > You can also check with %{?date} though, like you did. Done > > Optional: > > 1) Sort BuildRequires, one per line Done > 2) Have you considered building for both Python 2 and 3 in the same SPEC > file if supported by upstream? I tried that method which failed due to upstream only using Python 2 therefore unversionned python macros are a better options as you suggested. > > swatchbooker.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/swatchbook/codecs/html.py 644 /usr/bin/env > python > > Sorry, also this, make sure all .py files are 755. Done
(In reply to Luya Tshimbalanga from comment #7) > > > swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ral_bcs.py /usr/bin/env python > > > > Please fix. You can find an example here: > > > > http://pkgs.fedoraproject.org/cgit/rpms/python-rfc3987.git/tree/python- > > rfc3987.spec#n55 > > Looking at the tip part: > https://fedoraproject.org/wiki/Packaging_tricks?rd=PackageMaintainers/ > Packaging_Tricks#Remove_shebang_from_Python_libraries > > How to properly substitute "/usr/bin/env python" with "!/usr/bin/python"? I > currently use > > # Remove shebang > for lib in %{buildroot}%{python_sitelib}/swatchbook/*/*.py; do > sed '1{\@^#!/usr/bin/env python@d}' $lib > $lib.new && > touch -r $lib $lib.new && > mv $lib.new $lib > done > > but rpmlint keeps on complaining > > swatchbooker.noarch: E: script-without-shebang > /usr/lib/python2.7/site-packages/swatchbook/codecs/ooo_soc.py > > > > swatchbooker.noarch: E: non-executable-script > > /usr/lib/python2.7/site-packages/swatchbook/codecs/html.py 644 /usr/bin/env > > python > > > > Sorry, also this, make sure all .py files are 755. > > Done Ok, so I misinterpreted all of this, my bad. This is due to the fact that rpmlint was getting .py as script files and marking them as non executable. Library files (basically /usr/share/swatchbooker/*) should NOT have the shebang at the top and should NOT be marked as executables. So what you did is correct, but my comment about marking them as 755 was wrong. For main executables, make sure there you have a shebang and the interpreter should be !#/usr/bin/python. Just check with rpmlint after you're finished rebuilding so that the errors are silenced. After finishing this, I think the package can be approved.
Also, you did not post the updated SPEC file.
(In reply to Simone Caronni from comment #9) > Also, you did not post the updated SPEC file. Here is the updated spec SPEC: https://luya.fedorapeople.org/packages/SPECS/swatchbooker.spec SRPMS: https://luya.fedorapeople.org/packages/SRPMS/swatchbooker-0.8-0.1.20170131gitc5c8b02.fc25.src.rpm Resulting rpmlint: $ rpmlint rpmbuild/RPMS/noarch/swatchbooker-0.8-0.1.20170131gitc5c8b02.fc25.noarch.rpm swatchbooker.noarch: W: no-manual-page-for-binary swatchbooker swatchbooker.noarch: W: no-manual-page-for-binary sbconvert swatchbooker.noarch: W: no-manual-page-for-binary sbconvertor 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Package approved!
Thank you. Request for new package sent.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/swatchbooker