Bug 1441106 - [Geo-rep]: Unnecessary unlink call while processing rmdir
Summary: [Geo-rep]: Unnecessary unlink call while processing rmdir
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: geo-replication
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kotresh HR
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-11 08:41 UTC by Kotresh HR
Modified: 2017-05-30 18:49 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.11.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-30 18:49:52 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kotresh HR 2017-04-11 08:41:58 UTC
Description of problem:
Even though it is known to be 'RMDIR' from changelog, os.unlink
is being tried and os.rmdir is issued upon receiving
EISDIR. It's unnecessary.

Version-Release number of selected component (if applicable):
mainline

How reproducible:
Always

Actual results:
rmdir is issued upon receiving EISDIR from os.unlink

Expected results:
Directly issue rmdir for directories and os.unlink for unlinks

Additional info:

Comment 1 Worker Ant 2017-04-11 16:28:41 UTC
REVIEW: https://review.gluster.org/17041 (geo-rep: Remove unlink fop during rmdir) posted (#1) for review on master by Kotresh HR (khiremat)

Comment 2 Worker Ant 2017-04-13 11:47:33 UTC
REVIEW: https://review.gluster.org/17041 (geo-rep: Remove unlink fop during rmdir) posted (#2) for review on master by Kotresh HR (khiremat)

Comment 3 Worker Ant 2017-04-17 05:15:23 UTC
COMMIT: https://review.gluster.org/17041 committed in master by Aravinda VK (avishwan) 
------
commit 324509b340ebbab1e1531de9ba0a3ed6f4563753
Author: Kotresh HR <khiremat>
Date:   Mon Apr 10 06:52:51 2017 -0400

    geo-rep: Remove unlink fop during rmdir
    
    Even though it is known to be 'RMDIR', os.unlink
    was being tried and os.rmdir is issued upon receiving
    EISDIR. It's unnecessary unlink call for 'RMDIR'.
    Fixed the same.
    
    Change-Id: I8dbb680ee2c7f0c32b7799b1ed5351b3621cb42a
    BUG: 1441106
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: https://review.gluster.org/17041
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Aravinda VK <avishwan>

Comment 4 Shyamsundar 2017-05-30 18:49:52 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.