Bug 1441576 - [geo-rep]: rsync should not try to sync internal xattrs
Summary: [geo-rep]: rsync should not try to sync internal xattrs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: geo-replication
Version: 3.10
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Mohammed Rafi KC
QA Contact:
URL:
Whiteboard:
Depends On: 1353952
Blocks: glusterfs-3.10.2
TreeView+ depends on / blocked
 
Reported: 2017-04-12 08:58 UTC by Mohammed Rafi KC
Modified: 2017-05-31 20:44 UTC (History)
13 users (show)

Fixed In Version: glusterfs-3.10.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1353952
Environment:
Last Closed: 2017-05-31 20:44:48 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Mohammed Rafi KC 2017-04-12 08:58:36 UTC
+++ This bug was initially created as a clone of Bug #1353952 +++

+++ This bug was initially created as a clone of Bug #1327045 +++

Description of problem:
=======================

Found following errors in the geo-replication logs while the rsync retries the incomplete sync.

[2016-04-13 14:12:50.607055] E [resource(/rhs/brick1/b1):991:rsync] SSH: SYNC Error(Rsync): rsync: rsync_xal_set: lsetxattr(""/proc/1906/cwd/.gfid/00d486f4-97e0-44eb-9049-49c93df7f776"","trusted.glusterfs.fb163479-1572-4dc4-96d3-faf94715ef9f.xtime") failed: Operation not permitted (1)
[2016-04-13 14:12:50.607678] E [resource(/rhs/brick1/b1):991:rsync] SSH: SYNC Error(Rsync): rsync: rsync_xal_set: lsetxattr(""/proc/1906/cwd/.gfid/00d8cb77-c512-4747-9cfa-2e7a7289e280"","trusted.glusterfs.fb163479-1572-4dc4-96d3-faf94715ef9f.xtime") failed: Operation not permitted (1)
[2016-04-13 14:12:50.607942] E [resource(/rhs/brick1/b1):991:rsync] SSH: SYNC Error(Rsync): rsync: rsync_xal_set: lsetxattr(""/proc/1906/cwd/.gfid/01410949-268f-4a85-b716-fa66f3ac78df"","trusted.glusterfs.fb163479-1572-4dc4-96d3-faf94715ef9f.xtime") failed: Operation not permitted (1)
[2016-04-13 14:12:50.608335] E [resource(/rhs/brick1/b1):991:rsync] SSH: SYNC Error(Rsync): rsync: rsync_xal_set: lsetxattr(""/proc/1906/cwd/.gfid/0148c89c-0cf5-4169-9e0e-a5e88890a629"","trusted.glusterfs.fb163479-1572-4dc4-96d3-faf94715ef9f.xtime") failed: Operation not permitted (1)
[2016-04-13 14:12:50.608597] E [resource(/rhs/brick1/b1):991:rsync] SSH: SYNC Error(Rsync): rsync: rsync_xal_set: lsetxattr(""/proc/1906/cwd/.gfid/0188e977-db73-4ed2-9093-4943539afb8e"","trusted.glusterfs.fb163479-1572-4dc4-96d3-faf94715ef9f.xtime") failed: Operation not permitted (1)
[2016-04-13 14:12:50.608838] E [resource(/rhs/brick1/b1):991:rsync] SSH: SYNC Error(Rsync): rsync: rsync_xal_set: lsetxattr(""/proc/1906/cwd/.gfid/0193043a-6f26-43ed-84e5-7f3e0e977ecd"","trusted.glusterfs.fb163479-1572-4dc4-96d3-faf94715ef9f.xtime") failed: Operation not permitted (1)
[2016-04-13 14:12:50.609113] E [resource(/rhs/brick1/b1):991:rsync] SSH: SYNC Error(Rsync): rsync: rsync_xal_set: lsetxattr(""/proc/1906/cwd/.gfid/01d8abfd-d870-465f-883b-264aa8009ced"","trusted.glusterfs.fb163479-1572-4dc4-96d3-faf94715ef9f.xtime") failed: Operation not permitted (1)
[2016-04-13 14:12:50.609329] E [resource(/rhs/brick1/b1):991:rsync] SSH: SYNC Error(Rsync): rsync: rsync_xal_set: lsetxattr(""/proc/1906/cwd/.gfid/020ed975-cd04-4a16-b1e4-fad344256dbc"","trusted.glusterfs.fb163479-1572-4dc4-96d3-faf94715ef9f.xtime") failed: Operation not permitted (1)

rsync should not try syncing internal xattrs. 



Version-Release number of selected component (if applicable):
=============================================================




How reproducible:
=================
2/2

Steps Carried:
1. Ran geo-replication automated cases once with root and once with non-root.
2. Worker kept going ACTIVE => PASSIVE => ACTIVE due to input/output error
3. Incomplete changelogs were picked up for syncing which reported these errors in huge numbers


--- Additional comment from Rahul Hinduja on 2016-06-04 13:28:26 EDT ---

For reference:
==============

1. Create data
2. Create geo-rep session (non-root/root)
3. Sync via hybrid crawl should succeed. Lots of these errors are reported.

--- Additional comment from Vijay Bellur on 2016-07-08 09:52:49 EDT ---

REVIEW: http://review.gluster.org/14880 (geo-rep: filter out xtime attribute during getxattr) posted (#1) for review on master by Saravanakumar Arumugam (sarumuga)

--- Additional comment from Vijay Bellur on 2016-07-18 07:16:15 EDT ---

REVIEW: http://review.gluster.org/14880 (geo-rep: filter out xtime attribute during getxattr) posted (#2) for review on master by Saravanakumar Arumugam (sarumuga)

--- Additional comment from Vijay Bellur on 2016-07-21 07:20:00 EDT ---

REVIEW: http://review.gluster.org/14880 (geo-rep: filter out xtime attribute during getxattr) posted (#3) for review on master by Saravanakumar Arumugam (sarumuga)

--- Additional comment from Vijay Bellur on 2016-07-27 01:17:11 EDT ---

REVIEW: http://review.gluster.org/14880 (geo-rep: filter out xtime attribute during getxattr) posted (#4) for review on master by Saravanakumar Arumugam (sarumuga)

--- Additional comment from Vijay Bellur on 2016-07-27 05:03:13 EDT ---

REVIEW: http://review.gluster.org/14880 (geo-rep: filter out xtime attribute during getxattr) posted (#5) for review on master by Saravanakumar Arumugam (sarumuga)

--- Additional comment from Worker Ant on 2017-04-03 05:02:44 EDT ---

REVIEW: https://review.gluster.org/14880 (geo-rep: filter out xtime attribute during getxattr) posted (#6) for review on master by mohammed rafi  kc (rkavunga)

--- Additional comment from Worker Ant on 2017-04-03 11:14:57 EDT ---

REVIEW: https://review.gluster.org/14880 (geo-rep: filter out xtime attribute during getxattr) posted (#7) for review on master by mohammed rafi  kc (rkavunga)

--- Additional comment from Worker Ant on 2017-04-07 06:36:45 EDT ---

REVIEW: https://review.gluster.org/14880 (geo-rep: filter out xtime attribute during getxattr) posted (#8) for review on master by mohammed rafi  kc (rkavunga)

--- Additional comment from Worker Ant on 2017-04-11 05:15:03 EDT ---

COMMIT: https://review.gluster.org/14880 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit fddf202af078f09cf443fe76f8f43ad8eda2b4b6
Author: Saravanakumar Arumugam <sarumuga>
Date:   Fri Jul 8 19:10:45 2016 +0530

    geo-rep: filter out xtime attribute during getxattr
    
    georep gsyncd's xtime needs to filtered irrespective
    of any process access.
    
    This way, we can avoid (unnecessarily)syncing xtime attribute
    to slave, which may raise permission denied errors.
    
    test case modified to check for xtime xattr only in backend.
    
    Change-Id: I2390b703048d5cc747d91fa2ae884dc55de58669
    BUG: 1353952
    Signed-off-by: Saravanakumar Arumugam <sarumuga>
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: https://review.gluster.org/14880
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Kotresh HR <khiremat>
    Tested-by: Kotresh HR <khiremat>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 1 Worker Ant 2017-04-12 11:33:45 UTC
REVIEW: https://review.gluster.org/17046 (geo-rep: filter out xtime attribute during getxattr) posted (#1) for review on release-3.10 by mohammed rafi  kc (rkavunga)

Comment 2 Worker Ant 2017-05-03 09:04:54 UTC
COMMIT: https://review.gluster.org/17046 committed in release-3.10 by Raghavendra Talur (rtalur) 
------
commit 4ae86b077d1ef4cd0cb3f73397bb474026b3362f
Author: Saravanakumar Arumugam <sarumuga>
Date:   Fri Jul 8 19:10:45 2016 +0530

    geo-rep: filter out xtime attribute during getxattr
    
    georep gsyncd's xtime needs to filtered irrespective
    of any process access.
    
    This way, we can avoid (unnecessarily)syncing xtime attribute
    to slave, which may raise permission denied errors.
    
    test case modified to check for xtime xattr only in backend.
    
    Back port of>
    >BUG: 1353952
    >Signed-off-by: Saravanakumar Arumugam <sarumuga>
    >Signed-off-by: Mohammed Rafi KC <rkavunga>
    >Reviewed-on: https://review.gluster.org/14880
    >Smoke: Gluster Build System <jenkins.org>
    >Reviewed-by: Kotresh HR <khiremat>
    >Tested-by: Kotresh HR <khiremat>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    
    Change-Id: I2390b703048d5cc747d91fa2ae884dc55de58669
    BUG: 1441576
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: https://review.gluster.org/17046
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra Talur <rtalur>

Comment 3 Raghavendra Talur 2017-05-31 20:44:48 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.2, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.