Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolasdk.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvolasdk-1.3.0-0.1git75648e6.fc25.src.rpm Description: SDK for building Nuvola Player's web app scripts. Fedora Account System Username: martinkg %changelog * Tue Apr 11 2017 Martin Gansser <martinkg> - 1.3.0-0.1git75648e6 - Update to 1.3.0-0.1git75648e6 rpmlint -i nuvolasdk.spec /home/martin/rpmbuild/SRPMS/nuvolasdk-1.3.0-0.1git75648e6.fc25.src.rpm /home/martin/rpmbuild/RPMS/noarch/nuvolasdk-1.3.0-0.1git75648e6.fc25.noarch.rpm (none): E: error while reading /home/martin/rpmbuild/SRPMS/nuvolasdk-1.3.0-0.1git75648e6.fc25.src.rpm: 'str' object has no attribute 'decode' 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolasdk.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvolaplayer-3.1.2-1.fc25.src.rpm %changelog * Sun Apr 16 2017 Martin Gansser <martinkg> - 3.1.2-1 - Update to 3.1.2-1
sorry wrong ticket, forget last commit.
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolasdk.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvolasdk-1.3.0-1.fc25.src.rpm %changelog * Sun Apr 16 2017 Martin Gansser <martinkg> - 1.3.0-1 - Update to stable 1.3.0-1
I'll take this for a review.
First of all, I am not Python packager, so not sure I catch everything ... * Dependencies - Why there all the dependencies listed? I tried to remove all of them except of "python3-devel" and the build passed just fine. - Actually, trying to prepare some module via nuvolasdk, it seems that you should add: Requires: %{bindir}/scour Requires: %{bindir}/gm You have the runtime dependency on "lasem" there, but that is actually just library, you would need "lasem-render" executable or in case of Fedora "lasem-render-0.4". But since it has huge dependency chain, I'd suggest to go with GraphicsMagic instead, which has the smallest footprint of all the supported graphics engines. - Also, I am thinking if that might be just soft dependencies? Because in case you'd like to use "lasem" instead of "gm", why to force somebody. OTOH, if some Nuvola app is going to have build dependency on nuvolasdk, there should be probably hard dependency. I probably thinking too much ;) * Python macros - Shouldn't you use %py3_build and %py3_install macros instead of the "python setup.py" calls? * License - It should be only BSD, shouldn't it? * nuvolasdk/data/template/LICENSE-BSD.txt - This file should not be marked as %licesne IMO. This file is just part of a template for new project, not a real license file.
(In reply to Vít Ondruch from comment #5) > First of all, I am not Python packager, so not sure I catch everything ... > > * Dependencies > - Why there all the dependencies listed? I tried to remove all of them > except > of "python3-devel" and the build passed just fine. > - Actually, trying to prepare some module via nuvolasdk, it seems that you > should add: > > Requires: %{bindir}/scour > Requires: %{bindir}/gm done > > You have the runtime dependency on "lasem" there, but that is actually > just > library, you would need "lasem-render" executable or in case of Fedora > "lasem-render-0.4". But since it has huge dependency chain, I'd suggest > to > go with GraphicsMagic instead, which has the smallest footprint of all > the > supported graphics engines. > - Also, I am thinking if that might be just soft dependencies? Because > in case you'd like to use "lasem" instead of "gm", why to force somebody. > OTOH, if some Nuvola app is going to have build dependency on nuvolasdk, > there should be probably hard dependency. I probably thinking too much ;) > i used now GraphicsMagic > * Python macros > - Shouldn't you use %py3_build and %py3_install macros instead of the > "python > setup.py" calls? used mentioned macros > > * License > - It should be only BSD, shouldn't it? > ok, changed to BSD > * nuvolasdk/data/template/LICENSE-BSD.txt > - This file should not be marked as %licesne IMO. This file is just part > of a template for new project, not a real license file. unmarked nuvolasdk/data/template/LICENSE-BSD.txt as license file. NEW rpm files: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolasdk.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvolasdk-1.3.0-2.fc25.src.rpm %changelog * Thu Apr 13 2017 Martin Gansser <martinkg> - 1.3.0-2 - Changed license field to BSD only - Add RR %%{_bindir}/scour - Add RR %%{_bindir}/gm - Use %%py3_build and %%py3_install macros instead of the "python setup.py" calls - Unmark %%license LICENSE nuvolasdk/data/template/LICENSE-BSD.txt - Remove BR ImageMagick-devel, librsvg2-devel, librsvg2-tools - Remove BR python3-scour, vala-devel, lasem
I can't see any other issues. I asked also some python guys and they can't see nothing wrong with the package => APPROVED
Thanks for the review.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nuvolasdk
package has been built successfully on f25, f26 and rawhide.