Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1441858

Summary: Previewing a snapshot creates a copy for each VM disk
Product: [oVirt] ovirt-engine Reporter: Raz Tamir <ratamir>
Component: BLL.StorageAssignee: Tal Nisan <tnisan>
Status: CLOSED CURRENTRELEASE QA Contact: Raz Tamir <ratamir>
Severity: high Docs Contact:
Priority: unspecified    
Version: futureCC: bugs, ratamir, tnisan
Target Milestone: ovirt-4.2.0Keywords: Regression
Target Release: ---Flags: rule-engine: ovirt-4.2+
rule-engine: blocker+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-20 10:52:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine and vdsm logs
none
screenshot_preview none

Description Raz Tamir 2017-04-12 22:25:29 UTC
Created attachment 1271287 [details]
engine and vdsm logs

Description of problem:
When previewing a snapshot with more than 1 disk, and selecting the first option in the "Preview partial snapshot" dialog box (screenshot attached):
"Include in the previewed VM all disks (keep the disks that are not included in the snapshot as-is)."

The operation creates a copy of every VM disk. 



Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create a VM with 2 disks
2. Create a snapshot include the 2 VM disks
3. Preview the snapshot and select the first option


Actual results:
Every VM disk now appears twice (there are 2 bootable disks and every operation on one disk, applies on its copy too)

Expected results:
No exceptions in engine.log

Additional info:
The snapshot creation start at:
2017-04-13 01:07:04,610+03 INFO  [org.ovirt.engine.core.bll.snapshots.CreateAllSnapshotsFromVmCommand] (org.ovirt.thread.pool-7-thread-15) [e2e96bee-f0ec-4060-b367-5118c1479271] Running command: CreateAllSnapshotsFromVmCommand internal: false. Entities affected :  ID: d23ef003-8c3e-42b2-bc92-599379af98f4 Type: VMAction group MANIPULATE_VM_SNAPSHOTS with role type USER

Comment 1 Raz Tamir 2017-04-12 22:55:29 UTC
Created attachment 1271289 [details]
screenshot_preview

Comment 2 Yaniv Kaul 2017-04-13 07:42:35 UTC
Not sure why it's high severity. Is that a regression?

Comment 3 Raz Tamir 2017-04-13 09:08:33 UTC
Yes, it is a regression - keyword added

Comment 4 Tal Nisan 2017-04-13 13:36:32 UTC
Raz, given the version you've set I guess you tested it on master, can you please try and see if it reproduces on a 4.1 environment?

Comment 5 Raz Tamir 2017-04-13 13:54:55 UTC
Version-Release number of selected component (if applicable):
oVirt Engine Version: 4.2.0-0.0.master.20170408115943.gitea6bd62.el7.centos

Already tested on 4.1 and this doesn't happen there

Comment 6 Red Hat Bugzilla Rules Engine 2017-04-13 13:56:48 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 7 Raz Tamir 2017-05-23 23:02:00 UTC
Verified on ovirt-4.2.0-0.0.master.20170519193842.gitf4353fb6.el7.centos

Preview snapshot work as expected

Comment 8 Sandro Bonazzola 2017-12-20 10:52:44 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.