+++ This bug was initially created as a clone of Bug #1411607 +++ Description of problem: If for some reason MKDIR failed to sync, it will log and proceed further. Allowing it to further process will fail the entire directory tree syncing to slave. Version-Release number of selected component (if applicable): mainline How reproducible: Always Steps to Reproduce: 1. Setup master and slave gluster volume 2. Setup geo-rep session between them 3. Introduce directory sync failure by some means. To manually introduce this error, delete a directory on slave and Create files and directories under the deleted directory on master. Actual results: Geo-rep logs the errors and proceeds further Expected results: Geo-rep should not proceed if it's a directory error. Additional info: --- Additional comment from Worker Ant on 2017-01-10 01:22:34 EST --- REVIEW: http://review.gluster.org/16364 (geo-rep: Handle directory sync failure as hard error) posted (#1) for review on master by Kotresh HR (khiremat) --- Additional comment from Worker Ant on 2017-01-13 01:55:18 EST --- REVIEW: http://review.gluster.org/16364 (geo-rep: Handle directory sync failure as hard error) posted (#2) for review on master by Kotresh HR (khiremat) --- Additional comment from Worker Ant on 2017-01-13 08:00:08 EST --- COMMIT: http://review.gluster.org/16364 committed in master by Aravinda VK (avishwan) ------ commit 91ad7fe0ed8e8ce8f5899bb5ebbbbe57ede7dd43 Author: Kotresh HR <khiremat> Date: Tue Jan 10 00:30:42 2017 -0500 geo-rep: Handle directory sync failure as hard error If directory creation is failed, return immediately before further processing. Allowing it to further process will fail the entire directory tree syncing to slave. Hence master will log and raise exception if it's directory failure. Earlier, master used to log the failure and proceed. Change-Id: Iba2a8b5d3d0092e7a9c8a3c2cdf9e6e29c73ddf0 BUG: 1411607 Signed-off-by: Kotresh HR <khiremat> Reviewed-on: http://review.gluster.org/16364 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Aravinda VK <avishwan>
REVIEW: https://review.gluster.org/17051 (geo-rep: Handle directory sync failure as hard error) posted (#1) for review on release-3.8 by Kotresh HR (khiremat)
COMMIT: https://review.gluster.org/17051 committed in release-3.8 by Aravinda VK (avishwan) ------ commit 9c7a0aaf73993380c70570f99023b83064a85ddf Author: Kotresh HR <khiremat> Date: Tue Jan 10 00:30:42 2017 -0500 geo-rep: Handle directory sync failure as hard error If directory creation is failed, return immediately before further processing. Allowing it to further process will fail the entire directory tree syncing to slave. Hence master will log and raise exception if it's directory failure. Earlier, master used to log the failure and proceed. > BUG: 1411607 > Signed-off-by: Kotresh HR <khiremat> > Reviewed-on: http://review.gluster.org/16364 > Smoke: Gluster Build System <jenkins.org> > NetBSD-regression: NetBSD Build System <jenkins.org> > CentOS-regression: Gluster Build System <jenkins.org> > Reviewed-by: Aravinda VK <avishwan> Change-Id: Iba2a8b5d3d0092e7a9c8a3c2cdf9e6e29c73ddf0 BUG: 1441933 Signed-off-by: Kotresh HR <khiremat> Reviewed-on: https://review.gluster.org/17051 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Aravinda VK <avishwan>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.12, please open a new bug report. glusterfs-3.8.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://lists.gluster.org/pipermail/announce/2017-May/000072.html [2] https://www.gluster.org/pipermail/gluster-users/