Bug 1441991 - No notifications about finished service retirement
Summary: No notifications about finished service retirement
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.8.0
Hardware: All
OS: All
high
medium
Target Milestone: GA
: 5.9.0
Assignee: William Fitzgerald
QA Contact: Dmitry Misharov
URL:
Whiteboard: ui:service:notification:retirement
Depends On:
Blocks: 1444175
TreeView+ depends on / blocked
 
Reported: 2017-04-13 09:07 UTC by Dmitry Misharov
Modified: 2018-03-06 15:44 UTC (History)
8 users (show)

Fixed In Version: 5.9.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1444175 (view as bug list)
Environment:
Last Closed: 2018-03-06 15:44:15 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Screenshot of the bug (25.00 KB, image/png)
2017-04-13 09:07 UTC, Dmitry Misharov
no flags Details

Description Dmitry Misharov 2017-04-13 09:07:38 UTC
Created attachment 1271370 [details]
Screenshot of the bug

Description of problem:
There is no websocket notification about finished service retirement. There is "Service %service_name% has started retirement." notification, but "Service %service_name% retirement finished." is missing.

Version-Release number of selected component (if applicable):
5.8.0.10-beta1.20170411212748_e47d319

How reproducible:
Always

Steps to Reproduce:
1. Enable Embedded Ansbile role.
2. Wait until it will be enabled.
3. Navigate to Automation/Ansible.
4. Add some repository and credential.
5. Navigate Services/Catalogs/Catalog Item.
6. Add an "ansible playbook" catalog item.
7. Order the service from created catalog item.
8. Navigate to Services/My Services.
9. Retire the provisioned service.

Actual results:
In Notification/Events only "Service %service_name% has started retirement." is presented, despite of the service was successfully retired.

Expected results:
After finishing service retirement CFME should send a notification with message "Service %service_name% Retirement Finished." how it's done in service provisioning.

Comment 2 William Fitzgerald 2017-04-13 15:17:20 UTC
Dmitry,

Can I have access to your environment? 

Thanks

Billy

Comment 3 William Fitzgerald 2017-04-17 14:27:27 UTC
I have re-created the problem and testing the fix now

Comment 5 Tina Fitzgerald 2017-04-20 15:21:07 UTC
commit 0dd48a1aa242de4d1a34deebbbb46d2a222b3e49
Author: william fitzgerald <wfitzger>
Date:   Mon Apr 17 15:02:11 2017 -0400

    updated orchestration_stack typo

 app/models/mixins/retirement_mixin.rb                                        | 1 +
 spec/lib/miq_automation_engine/service_models/miq_ae_service_service_spec.rb | 1 +
 spec/lib/miq_automation_engine/service_models/miq_ae_service_vm_spec.rb      | 1 +
 spec/models/orchestration_stack/retirement_management_spec.rb                | 1 +
 spec/models/service/retirement_management_spec.rb                            | 1 +
 spec/models/vm/retirement_management_spec.rb                                 | 1 +
 6 files changed, 6 insertions(+)

Comment 6 Tina Fitzgerald 2017-04-20 15:29:29 UTC
$ git log -1
commit 64bdb46c9bc1ca4f53c8c56b2e6727786d8b2789
Author: Brandon Dunne <brandondunne>
Date:   Tue Apr 18 15:42:11 2017 -0400

    Merge pull request #14780 from billfitzgerald0120/retirement_mixin
    
    Automate - Added finish retirement notification.
    (cherry picked from commit 5164cd87dd1c55051704dc93a89fcd4dfbcdab21)

Comment 8 Dmitry Misharov 2017-10-12 07:56:04 UTC
Verified in 5.9.0.2.20171010190026_0413a06. There is a notification about service retirement.


Note You need to log in before you can comment on or make changes to this bug.