Bug 1442056

Created attachment 1271421 [details]
engine log

Description of problem:
There is no validation of option parameters of fence agents through RESTApi, though there is a validation for these options when you edit them in UI.

Eg. You can't add a fence agent with option port=rhv01 through UI (bz 1375646), but when you do the same with RESTApi, you have new fence agent with invalid parameter, which shows only in RESTApi and not in UI.

Version-Release number of selected component (if applicable):
4.1.1-9

How reproducible:
always

Steps to Reproduce:
1. CREATE request content is --  url:/ovirt-engine/api/hosts/$HOST_ID/fenceagents body:<agent>
    <address>$ADDRESS</address>
    <concurrent>false</concurrent>
    <options>
        <option>
            <name>port</name>
            <value>rhv01</value>
        </option>
    </options>
    <order>1</order>
    <password>$PASSWORD</password>
    <type>ipmilan</type>
    <username>$USERNAME</username>
</agent>

Actual results:
GET request content is --  url:/ovirt-engine/api/hosts/$HOST_ID/fenceagents 
<agents>
    <agent href="/ovirt-engine/api/hosts/$HOST_ID/fenceagents/$AGENT_ID" id="$AGENT_ID">
        <address>$ADDRESS</address>
        <encrypt_options>false</encrypt_options>
        <options>
            <option>
                <name>port</name>
                <value>rhv01</value>
            </option>
        </options>
        <order>1</order>
        <password>$PASSWORD</password>
        <type>ipmilan</type>
        <username>$USERNAME</username>
        <host href="/ovirt-engine/api/hosts/$HOST_ID" id="$HOST_ID"/>
    </agent>
</agents>

Expected results:
adding should not succeed

Additional info: