This should be localized: /** * Sends out a verification email to the given address. * @param addr The email address to which the email should be sent. */ private void sendVerificationEmail(String addr) { Mail mailer = new SmtpMail(); mailer.setRecipients(new String[] { addr }); mailer.setSubject("Email Verification"); mailer.setBody("This is a test"); mailer.send(); }
*** Bug 145785 has been marked as a duplicate of this bug. ***
There were much larger issues here. We needed the correct email text for one, including generating a url for verification. Also, the current code did not take into account the differences for satellite in the perl code.
Mass moving ON_DEV to ON_QA
This doesn't look like it should be ON_QA; at the very least there should be some sort of test plan.
TEST PLAN Login as an org admin on hosted. Go to users->click a user->confirm email address. change the email address and then click send verification. A verification email should be sent. confirm that this email has a more interesting body than "this is a test", account information, and a hashed url for verification. Confirm that the url has the correct host name and is either http or https accordingly. On satellite there should be no "confirm" for email address... simply "change". No email should be sent in a satellite setting.
looks good
its coming from dev-null.com, is that intentional?
That is the default value as defined by the web.default_mail_from configuration variable. If you would like it to be from someone else, override the above entry in /etc/rhn/rhn.conf. This is the current value in /etc/rhn/default/rhn_web.conf: web.default_mail_from = Red Hat Network <dev-null.com>
Moving back to ON_QA.