Bug 1442440 - Review Request: nodejs-nanoseconds - Convert the process.hrtime array to a single nanoseconds value
Summary: Review Request: nodejs-nanoseconds - Convert the process.hrtime array to a si...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews Node-RED 1442490
TreeView+ depends on / blocked
 
Reported: 2017-04-14 18:52 UTC by Jared Smith
Modified: 2017-09-22 18:07 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-09-22 18:07:55 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Jared Smith 2017-04-14 18:52:45 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-nanoseconds/nodejs-nanoseconds.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-nanoseconds/nodejs-nanoseconds-0.1.0-1.fc27.src.rpm
Description: Convert the process.hrtime array to a single nanoseconds value
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 🐧 2017-09-20 16:12:16 UTC
Tests fail with:

    assert.equal(nanoseconds([1298001, 09187662]), 1298001009187662);
                                       ^^^^^^^^
SyntaxError: Decimals with leading zeros are not allowed in strict mode.
    at createScript (vm.js:74:10)
    at Object.runInThisContext (vm.js:116:10)
    at Module._compile (module.js:588:28)
    at Object.Module._extensions..js (module.js:635:10)
    at Module.load (module.js:545:32)
    at tryModuleLoad (module.js:508:12)
    at Function.Module._load (module.js:500:3)
    at Module.require (module.js:568:17)
    at require (internal/module.js:11:18)
    at /usr/lib/node_modules/mocha/lib/mocha.js:219:27
    at Array.forEach (<anonymous>)
    at Mocha.loadFiles (/usr/lib/node_modules/mocha/lib/mocha.js:216:14)
    at Mocha.run (/usr/lib/node_modules/mocha/lib/mocha.js:468:10)
    at Object.<anonymous> (/usr/lib/node_modules/mocha/bin/_mocha:403:18)
    at Module._compile (module.js:624:30)
    at Object.Module._extensions..js (module.js:635:10)
    at Module.load (module.js:545:32)
    at tryModuleLoad (module.js:508:12)
    at Function.Module._load (module.js:500:3)
    at Function.Module.runMain (module.js:665:10)
    at startup (bootstrap_node.js:201:16)
    at bootstrap_node.js:626:3

Comment 3 Robert-André Mauchin 🐧 2017-09-22 17:25:53 UTC
All ok, package accepted.

Comment 4 Jared Smith 2017-09-22 17:36:13 UTC
'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1531'

Comment 5 Gwyn Ciesla 2017-09-22 17:38:01 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-nanoseconds

Comment 6 Jared Smith 2017-09-22 18:07:55 UTC
In rawhide, closing bug


Note You need to log in before you can comment on or make changes to this bug.