Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-is-valid-app/nodejs-is-valid-app.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-is-valid-app/nodejs-is-valid-app-0.3.0-1.fc27.src.rpm Description: Wrapper around is-valid-instance and is-registered for validating base plugins Fedora Account System Username: jsmith
Tests fail: + /usr/bin/mocha -R spec is-valid-app ✓ should export a function ✓ should return false if the instance is not valid 1) should allow custom instance types ✓ should return false if a plugin is registered already 3 passing (14ms) 1 failing 1) is-valid-app should allow custom instance types: AssertionError [ERR_ASSERTION]: 0 == 2 + expected - actual +2 -0 at Context.<anonymous> (test.js:47:12)
Can you please test again? This is working fine for me: https://koji.fedoraproject.org/koji/taskinfo?taskID=28446214
- Latest version packaged - License ok - Builds in Mock - No rpmlint errors - Conforms to the Packaging Guidelines Package approved.
Package was never imported, it will need a fresh review. Jared, are you still interested in packaging this?
@mattia.verga No, I'm no longer doing any NodeJS packaging in Fedora. Feel free to resubmit if you are interested in packaging it.
Thanks