Created attachment 1271996 [details] exception on network vm deletion cancellation Description of problem: When user tries to delete a virtual machine (in suspended mode) and cancels the operation from the confirmation dialog, an exception occurs on network -> virtual machine sub-tab. Uncaught exception occurred. Please try reloading the page. Details: (TypeError) __gwt$exception: <skipped>: a is null Please have your administrator check the UI logs Version-Release number of selected component (if applicable): Red Hat Virtualization Manager Version: 4.1.1.8-0.1.el7 How reproducible: always Steps to Reproduce: 1. login to admin portal 2. go to networks -> virtual machines 3. select a virtual machine from 'Not Running' list 4. Click on delete and press cancel on the confirmation dialog. Actual results: exception occurs. Expected results: There should not be any exception. Additional info:
Created attachment 1272228 [details] UI log
The issue is that the vm_dynamic.vm_fqdn can be null or empty string. If the vm_fqdn is null, this subtab starts to throw exceptions. You don't even need to press remove, it is enough to wait long enough and the tab will be flood by exceptions.
(In reply to Tomas Jelinek from comment #4) > The issue is that the vm_dynamic.vm_fqdn can be null or empty string. How common can that be? What's the workaround? Is that a regression? > If the vm_fqdn is null, this subtab starts to throw exceptions. You don't > even need to press remove, it is enough to wait long enough and the tab will > be flood by exceptions.
(In reply to Yaniv Kaul from comment #5) > (In reply to Tomas Jelinek from comment #4) > > The issue is that the vm_dynamic.vm_fqdn can be null or empty string. > > How common can that be? What's the workaround? > Is that a regression? It is not a regression, it has been this way for a long time. You will have nulls there after you turn the VM off (e.g. the ResourceManager.resetVmAttributes() is executed clearing the VM up). You will get empty values when you just create a VM because it is created by default with empty values. As a followup we may consider unifying this, but most of the code already handles both null and empty values in fqdn, the exception is SubTabNetworkVmView. > > > If the vm_fqdn is null, this subtab starts to throw exceptions. You don't > > even need to press remove, it is enough to wait long enough and the tab will > > be flood by exceptions.
No UI error on both, Cancel and OK. verified in ovirt-engine-webadmin-portal-4.1.3-0.1.el7.noarch