Bug 1442782 - nm-applet wakes up several hundred times per second when a VPN is in use
Summary: nm-applet wakes up several hundred times per second when a VPN is in use
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: network-manager-applet
Version: 25
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Beniamino Galvani
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-17 13:47 UTC by dann
Modified: 2017-12-12 10:17 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-12 10:17:09 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description dann 2017-04-17 13:47:08 UTC
When a VPN is in use (with openconnect in this case, I haven't tried other VPN kinds), nm-applet wakes up several hundred times per second.  This happens regardless if there is traffic over the VPN or if there's no traffic.  This is not good for the battery life...

When the VPN is not connected nm-applet does not wake up all the time.

The VPN is managed by NetworkManager.

This happens when nm-applet is used with XFCE, I didn't checke other desktop environments.


strace -p on the nm-applet process shows this: 


poll([{fd=3, events=POLLIN}], 1, -1)    = 1 ([{fd=3, revents=POLLIN}])
recvfrom(3, "\0\0\0\0", 4, 0, NULL, NULL) = 4
recvmsg(3, {msg_namelen=0}, 0)          = -1 EAGAIN (Resource temporarily unavailable)
recvmsg(3, {msg_namelen=0}, 0)          = -1 EAGAIN (Resource temporarily unavailable)
poll([{fd=3, events=POLLIN|POLLOUT}], 1, -1) = 1 ([{fd=3, revents=POLLOUT}])
writev(3, [{iov_base="%(\1\0", iov_len=4}, {iov_base=NULL, iov_len=0}, {iov_base="", iov_len=0}], 3) = 4
recvmsg(3, {msg_namelen=0}, 0)          = -1 EAGAIN (Resource temporarily unavailable)
poll([{fd=3, events=POLLIN|POLLOUT}], 1, -1) = 1 ([{fd=3, revents=POLLOUT}])
writev(3, [{iov_base="+(\1\0", iov_len=4}, {iov_base=NULL, iov_len=0}, {iov_base="", iov_len=0}], 3) = 4
poll([{fd=3, events=POLLIN}], 1, -1)    = 1 ([{fd=3, revents=POLLIN}])
recvmsg(3, {msg_name=NULL, msg_namelen=0, msg_iov=[{iov_base="\1\1\325z\0\0\0\0\"\0`\1\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", iov_len=4096}], msg_iovlen=1, msg_controllen=0, msg_flags=0}, 0) = 32
recvmsg(3, {msg_namelen=0}, 0)          = -1 EAGAIN (Resource temporarily unavailable)
recvmsg(3, {msg_namelen=0}, 0)          = -1 EAGAIN (Resource temporarily unavailable)
clock_gettime(CLOCK_MONOTONIC, {tv_sec=690201, tv_nsec=877424086}) = 0
recvmsg(3, {msg_namelen=0}, 0)          = -1 EAGAIN (Resource temporarily unavailable)
poll([{fd=3, events=POLLIN}, {fd=4, events=POLLIN}, {fd=5, events=POLLIN}], 3, 99^Cstrace: Process 1377 detached
 <detached ...>

Comment 1 Beniamino Galvani 2017-04-19 07:31:48 UTC
Which version of NetworkManager and network-manager-applet do you have?

Comment 2 Beniamino Galvani 2017-04-19 12:45:49 UTC
Pushed fix for master to branch bg/vpn-state-rh1442782.

Comment 3 Thomas Haller 2017-04-19 16:16:52 UTC
(In reply to Beniamino Galvani from comment #2)
> Pushed fix for master to branch bg/vpn-state-rh1442782.

lgtm.

From the commit messages it is not clear which one fixes this bug (and why). could you elaborate?

Also, add "Fixes: c6e787aac808b2b434455eae8be0137cbab4892a" for commit "applet: fix handling of VPN state changes"

Comment 4 dann 2017-04-19 17:12:33 UTC
(In reply to Beniamino Galvani from comment #1)
> Which version of NetworkManager and network-manager-applet do you have?

NetworkManager-1.4.4-3.fc25.x86_64
network-manager-applet-1.4.0-1.fc25.x86_64

Comment 5 Beniamino Galvani 2017-04-20 13:32:33 UTC
(In reply to Thomas Haller from comment #3)
> From the commit messages it is not clear which one fixes this bug (and why).
> could you elaborate?

I have updated the commit messages. On master, both "applet: fix handling of VPN state changes" and "applet: subscribe to notify::state property of unsupported devices" are needed to fix the issue. In 1.4 versions only the latter.

> Also, add "Fixes: c6e787aac808b2b434455eae8be0137cbab4892a" for commit
> "applet: fix handling of VPN state changes"

Added, thanks.

Comment 6 Thomas Haller 2017-04-20 14:38:51 UTC
lgtm

Comment 8 Fedora End Of Life 2017-11-16 18:37:41 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 9 Fedora End Of Life 2017-12-12 10:17:09 UTC
Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.