Bug 1442788 - Cleanup timer wheel in glfs_fini()
Summary: Cleanup timer wheel in glfs_fini()
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: libgfapi
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Poornima G
QA Contact: bugs@gluster.org
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-17 14:12 UTC by Poornima G
Modified: 2017-09-05 17:26 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.12.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-05 17:26:58 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Poornima G 2017-04-17 14:12:10 UTC
Description of problem:

If the client process uses timer_wheel, the cleanup for the same should be present in glfs_init, if not it could lead to crashes.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-04-17 14:13:09 UTC
REVIEW: https://review.gluster.org/17068 (gfapi: Add the timer-wheel cleanup in glfs_fini) posted (#1) for review on master by Poornima G (pgurusid)

Comment 2 Worker Ant 2017-04-24 09:38:14 UTC
REVIEW: https://review.gluster.org/17068 (core: make the per glusterfs_ctx_t timer-wheel refcounted) posted (#2) for review on master by Niels de Vos (ndevos)

Comment 3 Worker Ant 2017-04-29 13:05:06 UTC
REVIEW: https://review.gluster.org/17068 (core: make the per glusterfs_ctx_t timer-wheel refcounted) posted (#3) for review on master by Poornima G (pgurusid)

Comment 4 Worker Ant 2017-05-01 09:30:18 UTC
COMMIT: https://review.gluster.org/17068 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 73fcf3a874b2049da31d01b8363d1ac85c9488c2
Author: Niels de Vos <ndevos>
Date:   Mon Apr 17 15:50:07 2017 +0530

    core: make the per glusterfs_ctx_t timer-wheel refcounted
    
    xlators can use a 'global' timer-wheel for scheduling events. This
    timer-wheel is managed per glusterfs_ctx_t, but does not need to be
    allocated for every graph. When an xlator wants to use the timer-wheel,
    it will be instanciated on demand, and provided to xlators that request
    it later on.
    
    By adding a reference counter to the glusterfs_ctx_t for the
    timer-wheel, the threads and structures can be cleaned up when the last
    xlator does not have a need for it anymore. In general, the xlators
    request the timer-wheel in init(), and they should return it in fini().
    
    Because the timer-wheel is managed per glusterfs_ctx_t, the functions
    can be added to ctx.c and do not need to live in their very minimal
    tw.[ch] files.
    
    Change-Id: I19d225b39aaa272d9005ba7adc3104c3764f1572
    BUG: 1442788
    Reported-by: Poornima G <pgurusid>
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: https://review.gluster.org/17068
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    Reviewed-by: Zhou Zhengping <johnzzpcrystal>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 5 Shyamsundar 2017-09-05 17:26:58 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.