Spec URL: https://decathorpe.fedorapeople.org/packages/libgsignon-glib.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/libgsignon-glib-2.4.1-1.20161228.git03d9c64.fc26.src.rpm Description: This project is a library for managing single signon credentials which can be used from GLib applications. It is effectively a GLib binding for the D-Bus API provided by gsignond. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=19048060 PS: The additional support for python is not enabled on purpose, since it only supports python2.
Taking this review.
A few issues: > Requires: dbus%{?isa} > Requires: gsignond%{?isa} The macro should be "%{?_isa}". > %package devel > Summary: GSignOn daemon development files The summary is wrong for this library. > %files devel > %{_bindir}/gsso-example Move this into its own subpackage, as it doesn't depend on the devel content at all, and isn't needed for devel stuff.
Issues are fixed, same links.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* LGPL (v2.1)", "LGPL (v2.1 or later)", "LGPL (v2.1)", "Unknown or generated". 52 files have unknown license. Detailed output of licensecheck in /home/makerpm/1442853-libgsignon- glib/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/girepository-1.0, /usr/share/vala/vapi, /usr/share/gir-1.0, /usr/share/vala [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libgsignon-glib-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libgsignon-glib-2.4.1-1.20161228.git03d9c64.fc27.x86_64.rpm libgsignon-glib-devel-2.4.1-1.20161228.git03d9c64.fc27.x86_64.rpm libgsignon-glib-example-2.4.1-1.20161228.git03d9c64.fc27.x86_64.rpm libgsignon-glib-debuginfo-2.4.1-1.20161228.git03d9c64.fc27.x86_64.rpm libgsignon-glib-2.4.1-1.20161228.git03d9c64.fc27.src.rpm 0 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (debuginfo) ------------------- Checking: libgsignon-glib-debuginfo-2.4.1-1.20161228.git03d9c64.fc27.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory libgsignon-glib-example.x86_64: W: spelling-error %description -l en_US signon -> chignon, signor, sign on libgsignon-glib-example.x86_64: W: spelling-error %description -l en_US gsignond -> monsignor libgsignon-glib-example.x86_64: W: only-non-binary-in-usr-lib libgsignon-glib-example.x86_64: W: no-documentation libgsignon-glib-example.x86_64: W: hidden-file-or-dir /usr/lib/.build-id libgsignon-glib-example.x86_64: W: hidden-file-or-dir /usr/lib/.build-id libgsignon-glib-example.x86_64: W: no-manual-page-for-binary gsso-example libgsignon-glib-devel.x86_64: W: spelling-error %description -l en_US signon -> chignon, signor, sign on libgsignon-glib-devel.x86_64: W: spelling-error %description -l en_US gsignond -> monsignor libgsignon-glib-devel.x86_64: W: only-non-binary-in-usr-lib libgsignon-glib-devel.x86_64: W: no-documentation libgsignon-glib.x86_64: W: spelling-error %description -l en_US signon -> chignon, signor, sign on libgsignon-glib.x86_64: W: spelling-error %description -l en_US gsignond -> monsignor libgsignon-glib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgsignon-glib.so.1.0.0 /lib64/libgthread-2.0.so.0 libgsignon-glib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgsignon-glib.so.1.0.0 /lib64/libpthread.so.0 libgsignon-glib.x86_64: W: no-documentation libgsignon-glib.x86_64: W: hidden-file-or-dir /usr/lib/.build-id libgsignon-glib.x86_64: W: hidden-file-or-dir /usr/lib/.build-id 4 packages and 0 specfiles checked; 0 errors, 18 warnings. Requires -------- libgsignon-glib-example (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgsignon-glib(x86-64) libgsignon-glib.so.1()(64bit) libgthread-2.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libgsignon-glib-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libgsignon-glib(x86-64) libgsignon-glib.so.1()(64bit) pkgconfig(gio-unix-2.0) pkgconfig(glib-2.0) pkgconfig(gobject-2.0) libgsignon-glib (rpmlib, GLIBC filtered): /sbin/ldconfig dbus(x86-64) gsignond(x86-64) libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) libgsignon-glib-debuginfo (rpmlib, GLIBC filtered): Provides -------- libgsignon-glib-example: libgsignon-glib-example libgsignon-glib-example(x86-64) libgsignon-glib-devel: libgsignon-glib-devel libgsignon-glib-devel(x86-64) pkgconfig(libgsignon-glib) libgsignon-glib: libgsignon-glib libgsignon-glib(x86-64) libgsignon-glib.so.1()(64bit) libgsignon-glib-debuginfo: libgsignon-glib-debuginfo libgsignon-glib-debuginfo(x86-64) Source checksums ---------------- https://gitlab.com/accounts-sso/libgsignon-glib/repository/archive.tar.gz?ref=03d9c64c0cd1b9a5c399e531f6d83d2f2998094c#/libgsignon-glib-03d9c64.tar.gz : CHECKSUM(SHA256) this package : 71f155008a14f3daf89b747d8893f3584a3c4a5929666ef5904ddc5dc42f23b9 CHECKSUM(SHA256) upstream package : 71f155008a14f3daf89b747d8893f3584a3c4a5929666ef5904ddc5dc42f23b9 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/bin/fedora-review -b 1442853 -m ../../home/makerpm/fedora-rawhide-x86_64-koji Buildroot used: fedora-rawhide-x86_64-koji Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Looks good to me. PACKAGE APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libgsignon-glib
libgsignon-glib-2.4.1-1.20161228.git03d9c64.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7da348eda5
libgsignon-glib-2.4.1-1.20161228.git03d9c64.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-28e7fc0b45
libgsignon-glib-2.4.1-1.20161228.git03d9c64.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-28e7fc0b45
libgsignon-glib-2.4.1-1.20161228.git03d9c64.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7da348eda5
libgsignon-glib-2.4.1-1.20161228.git03d9c64.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.