Bug 1443064 - vdsm.conf isn't being written due to vintage condition
Summary: vdsm.conf isn't being written due to vintage condition
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-host-deploy
Classification: oVirt
Component: Plugins.VDSM
Version: master
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.1.2
: 1.6.4
Assignee: Simone Tiraboschi
QA Contact: Aleksei Slaikovskii
URL:
Whiteboard:
Depends On:
Blocks: 1447670
TreeView+ depends on / blocked
 
Reported: 2017-04-18 12:08 UTC by Leon Goldberg
Modified: 2017-05-23 08:16 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-05-23 08:16:58 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: blocker+
lsvaty: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 74025 0 master MERGED vdsm: fix config decorator 2017-04-19 16:05:40 UTC
oVirt gerrit 75355 0 master POST config plugin: remove vintage condition on validation 2017-04-20 08:47:25 UTC
oVirt gerrit 75666 0 ovirt-host-deploy-1.6 MERGED vdsm: fix config decorator 2017-04-20 06:34:45 UTC
oVirt gerrit 76319 0 ovirt-host-deploy-1.6 MERGED Removing closeup stage from vdsm config plugin. 2017-05-03 07:51:01 UTC

Description Leon Goldberg 2017-04-18 12:08:47 UTC 
Description of problem:
The function responsible for actually writing vdsm.conf ("_validate") has a vintage condition to it.

How reproducible:
100%

Steps to Reproduce:
1. Add non-vintage host.

Actual results:
vdsm.conf remains commented out.

Expected results:
vdsm.conf is written according to the host's configuration
Comment 1 Dan Kenigsberg 2017-04-19 08:51:57 UTC 
Since https://gerrit.ovirt.org/#/c/53531/5/src/plugins/ovirt-host-deploy/vdsm/config.py o-h-d no longer modifies vdsm.conf even if requested to do so in its config.
Comment 2 Red Hat Bugzilla Rules Engine 2017-04-19 12:19:50 UTC 
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
Comment 3 Aleksei Slaikovskii 2017-05-16 12:00:08 UTC 
Verified on ovirt-host-deploy-1.6.4-1.el7ev.noarch
Note You need to log in before you can comment on or make changes to this bug.