Bug 1443553 - Backups fail when configuration has mixed lvm and non-lvm backup points
Summary: Backups fail when configuration has mixed lvm and non-lvm backup points
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: rsnapshot
Version: el6
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert Scheck
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-19 12:58 UTC by info@kobaltwit.be
Modified: 2020-01-07 00:26 UTC (History)
2 users (show)

Fixed In Version: rsnapshot-1.4.3-1.el7 rsnapshot-1.4.3-1.el6_10
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-05 00:07:33 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Output of rsnapshot after running it with one lvm backup point and one plain local directory backup point (1.75 KB, text/plain)
2017-04-19 12:58 UTC, info@kobaltwit.be
no flags Details
A patch to fix rsnapshot when a mix of lvm and non-lvm backup points is used (596 bytes, patch)
2017-04-19 13:00 UTC, info@kobaltwit.be
no flags Details | Diff

Description info@kobaltwit.be 2017-04-19 12:58:12 UTC
Created attachment 1272599 [details]
Output of rsnapshot after running it with one lvm backup point and one plain local directory backup point

Description of problem:
I have a backup configuration in which some backup points are lvm based and others are not. In this situation the backup errors out on the first non-lvm backup point after at least one lvm backup point was handled.

Version-Release number of selected component (if applicable):
rsnapshot.noarch 0:1.4.2-2.el6

How reproducible:
Always

Steps to Reproduce:
1. create a backup configuration in which the first backup point is an lvm based backup and the second one is a normal directory backup (or any other backup that's not lvm based). To make the next steps below consistent, also set sync_first to 1

2. do a test run by executing 'rsnapshot -t sync'
3. the same error also happens with a normal run 'rsnapshot sync', but the test run is just faster. 

Actual results:
Observe the commands listed: first the cycle for the lvm backup point is properly described. When the commands for the non-lvm backup point are to be printed, you'll first notice a number of warnings about the use of uninitialized variables and then an error.

Expected results:
Test and full run complete without error

Additional info:
I've traced this back to improperly undefining the two variables at the end of the lvm backup point run instead of resetting them to 0 (their initial state before any backup has run). Other parts of the code expect these variables to exist at all times and only checks whether they are or are not 0 or 1 depending on the situation in which they are tested.

I'll attach the output I get from the faulty rsnapshot script and a patch that fixes the issue for me.

Comment 1 info@kobaltwit.be 2017-04-19 13:00:26 UTC
Created attachment 1272608 [details]
A patch to fix rsnapshot when a mix of lvm and non-lvm backup points is used

Comment 2 Fedora Update System 2019-12-12 20:35:26 UTC
FEDORA-EPEL-2019-6f33b901f5 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-6f33b901f5

Comment 3 Fedora Update System 2019-12-12 20:37:51 UTC
FEDORA-EPEL-2019-50a64de266 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-50a64de266

Comment 4 Fedora Update System 2019-12-13 02:01:52 UTC
rsnapshot-1.4.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-6f33b901f5

Comment 5 Fedora Update System 2019-12-13 03:04:57 UTC
rsnapshot-1.4.3-1.el6_10 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-50a64de266

Comment 6 Fedora Update System 2020-01-05 00:07:33 UTC
rsnapshot-1.4.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2020-01-07 00:26:20 UTC
rsnapshot-1.4.3-1.el6_10 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.