Bug 1443740 - Simplify Container and Container Definition Models
Summary: Simplify Container and Container Definition Models
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.9.0
Assignee: Ari Zellner
QA Contact: juwatts
URL:
Whiteboard: container
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-19 21:15 UTC by Federico Simoncelli
Modified: 2018-04-09 13:10 UTC (History)
6 users (show)

Fixed In Version: 5.9.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-01 13:11:36 UTC
Category: ---
Cloudforms Team: Container Management
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2018:0380 0 normal SHIPPED_LIVE Moderate: Red Hat CloudForms security, bug fix, and enhancement update 2018-03-01 18:37:12 UTC

Description Federico Simoncelli 2017-04-19 21:15:02 UTC
Description of problem:
In an early design the Container Definition table was supposed to be used for Replication Controllers information as well. For that reason it is decoupled from the Container table.

It is worth investigating if we can simplify the Container and Container Definition models (1-to-1) by consolidating the data into a single table.

Comment 2 Dave Johnson 2017-07-14 02:50:35 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set it to Low/Low.

Comment 3 Beni Paskin-Cherniavsky 2017-09-24 15:07:03 UTC
Done by Ari.  PRs involved (perhaps incomplete):

https://github.com/ManageIQ/manageiq-schema/pull/24
https://github.com/ManageIQ/manageiq/pull/15393
https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/42
https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/76
https://github.com/ManageIQ/manageiq-providers-openshift/pull/40
https://github.com/ManageIQ/manageiq-ui-classic/pull/1760
https://github.com/ManageIQ/manageiq-automation_engine/pull/55
https://github.com/ManageIQ/manageiq/pull/15721

QE: this was just a refactoring, no new functionality.
Old functionality this could have broken if buggy, would be nice to verify:
After refresh UI shows partial info for pod containers that have spec but no status, and full info for running containers.
I *think* a simple way to get pod stuck without containerStatuses is specify non-existing image.  Another is request > quota so the pod is not scheduled.

Comment 4 juwatts 2017-12-01 19:49:44 UTC
CFME Version:
5.9.0.11.20171127204214_e316988

Verification:
Verified via regression testing of Inventory Refresh

Comment 7 errata-xmlrpc 2018-03-01 13:11:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0380


Note You need to log in before you can comment on or make changes to this bug.