Bug 1443759 - Review Request: nodejs-is-error - Detect whether a value is an error
Summary: Review Request: nodejs-is-error - Detect whether a value is an error
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1364669 1443738 1443755
Blocks: nodejs-reviews Node-RED 1443764
TreeView+ depends on / blocked
 
Reported: 2017-04-19 22:43 UTC by Jared Smith
Modified: 2017-09-21 15:33 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-09-21 15:33:21 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Jared Smith 2017-04-19 22:43:40 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-is-error/nodejs-is-error.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-is-error/nodejs-is-error-2.2.1-1.fc27.src.rpm
Description: Detect whether a value is an error
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 🐧 2017-09-20 07:18:39 UTC
I've got a build error with the test I think:

+ /usr/bin/tap test/index.js
+ tap-spec
    ✔ test/index.js ...................................... 14/14
    total ................................................. 14/14
    ✔ undefined
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.TnH3e5 (%check)
    Bad exit status from /var/tmp/rpm-tmp.TnH3e5 (%check)

See https://koji.fedoraproject.org/koji/taskinfo?taskID=21979908

Comment 2 Robert-André Mauchin 🐧 2017-09-20 07:23:49 UTC
 - Fixed it by modifyinq the test, like specified in package.json:

%{__nodejs} test/index.js | tap-spec


Package is accepted but please don't forget to make this trivial change before import.

Comment 3 Jared Smith 2017-09-20 13:44:02 UTC
'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1409'

Comment 4 Gwyn Ciesla 2017-09-20 14:06:21 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-is-error

Comment 5 Jared Smith 2017-09-21 15:33:21 UTC
In rawhide, closing bug


Note You need to log in before you can comment on or make changes to this bug.