Bug 1444023 - io-stats xlator leaks memory when fini() is called
Summary: io-stats xlator leaks memory when fini() is called
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1425623
TreeView+ depends on / blocked
 
Reported: 2017-04-20 12:51 UTC by Niels de Vos
Modified: 2017-05-30 18:50 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.11.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-30 18:50:19 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)
Leaks fixed with the posted patch (6.75 KB, text/plain)
2017-04-20 12:53 UTC, Niels de Vos
no flags Details

Description Niels de Vos 2017-04-20 12:51:42 UTC
Description of problem:
the io-stats xlator allocates a (xlator_t *this)->private structure in init(), but does not free it completely in fini().

Kinglong posted https://github.com/gluster/glusterfs/pull/177 with some fixes.

Comment 1 Niels de Vos 2017-04-20 12:53:21 UTC
Created attachment 1272954 [details]
Leaks fixed with the posted patch

Comment 2 Worker Ant 2017-04-20 12:53:56 UTC
REVIEW: https://review.gluster.org/17089 (io-stats: fix some memory leak after fini) posted (#2) for review on master by Anonymous Coward

Comment 3 Worker Ant 2017-04-27 10:44:52 UTC
COMMIT: https://review.gluster.org/17089 committed in master by Niels de Vos (ndevos) 
------
commit 232882ac6f93ebac847715f522a99960bcfb11a6
Author: Kinglong Mee <kinglongmee>
Date:   Thu Apr 20 02:08:32 2017 -0400

    io-stats: fix some memory leak after fini
    
    Change-Id: Id057b711d7f615c6d2db1ebbca2f17d0afacb2ae
    BUG: 1444023
    Signed-off-by: Kinglong Mee <mijinlong>
    Reviewed-on: https://review.gluster.org/17089
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Niels de Vos <ndevos>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 4 Shyamsundar 2017-05-30 18:50:19 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.