Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1444210

Summary: Support VF Trust mode
Product: Red Hat Enterprise Linux 7 Reporter: Robert LeBlanc <robert>
Component: iprouteAssignee: Phil Sutter <psutter>
Status: CLOSED CURRENTRELEASE QA Contact: BaseOS QE Security Team <qe-baseos-security>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.3CC: aloughla, atragler, robert
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-24 15:39:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Robert LeBlanc 2017-04-20 20:58:51 UTC 
Description of problem:

We are not able to set the VF trust mode with the current version of iproute. This prevents being able to support a bridge on a VF.

Version-Release number of selected component (if applicable):
# ip -V
ip utility, iproute2-ss130716
# yum list installed | grep iproute
iproute.x86_64                        3.10.0-54.el7_2.1              @updates

How reproducible:
Always

Steps to Reproduce:
1. Enable SR-IOV on an adapter (Mellanox ConnectX-4 in this case)
2. ip link set ens1 vf 0 trust on
3.

Actual results:
# ip link set ens1 vf 0 trust on
Command line is not complete. Try option "help"
# ip link show dev ens1
4: ens1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT qlen 1000
    link/ether 24:8a:07:5b:1c:00 brd ff:ff:ff:ff:ff:ff
    vf 0 MAC 00:00:00:00:00:00, spoof checking off, link-state auto
    vf 1 MAC 00:00:00:00:00:00, spoof checking off, link-state auto

Expected results:
# ./ip link set ens1 vf 0 trust on
# ./ip link show dev ens1
4: ens1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000
    link/ether 24:8a:07:5b:1c:00 brd ff:ff:ff:ff:ff:ff
    vf 0 MAC 00:00:00:00:00:00, spoof checking off, link-state auto, trust on, query_rss off
    vf 1 MAC 00:00:00:00:00:00, spoof checking off, link-state auto, trust on, query_rss off

Additional info:
Upstream commit b6d77d9ee312246146e9b5ca70a8a1426898b484 adds the trust mode support.

commit b6d77d9ee312246146e9b5ca70a8a1426898b484
Author: Hiroshi Shimamoto <h-shimamoto.nec.com>
Date:   Fri Feb 26 02:40:18 2016 +0000

    iplink: Support VF Trust
    
    Add IFLA_VF_TRUST message to trust the VF.
    PF can accept some privileged operation from the trusted VF.
    For example, ixgbe PF doesn't allow to enable VF promiscuous mode until
    the VF is trusted because it may hurt performance.
    
    To trust VF.
     # ip link set dev eth0 vf 1 trust on
    
    To untrust VF.
     # ip link set dev eth0 vf 1 trust off
    
    Signed-off-by: Hiroshi Shimamoto <h-shimamoto.nec.com>
Comment 2 Phil Sutter 2017-04-24 14:27:14 UTC 
Hi Robert,

(In reply to Robert LeBlanc from comment #0)
> Description of problem:
> 
> We are not able to set the VF trust mode with the current version of
> iproute. This prevents being able to support a bridge on a VF.

The requested functionality is available in iproute since RHEL7.3.

> Version-Release number of selected component (if applicable):
> # ip -V
> ip utility, iproute2-ss130716
> # yum list installed | grep iproute
> iproute.x86_64                        3.10.0-54.el7_2.1              @updates

This looks like you're running RHEL7.2?! Do you require VF trust support to be
backported to 7.2 or is 7.3 fine with you?

Adding this to 7.2 z-stream would require adding kernel support as well.

Cheers, Phil
Comment 3 Robert LeBlanc 2017-04-24 14:46:46 UTC 
We will probably be just fine with the functionality in 7.3. We will either backport the packages or move to 7.3. We are in a freeze at the moment, so we haven't tested 7.3 yet.

Thanks for following up.
Comment 4 Phil Sutter 2017-04-24 15:39:45 UTC 
Hi Robert,

(In reply to Robert LeBlanc from comment #3)
> We will probably be just fine with the functionality in 7.3. We will either
> backport the packages or move to 7.3. We are in a freeze at the moment, so
> we haven't tested 7.3 yet.

OK, thanks for clarifying. I'll close this ticket then. Please just keep in
mind you will have to use both iproute *and* kernel package from RHEL7.3 in
order to get the functionality into RHEL7.2.

Thanks, Phil