*** Bug 1444376 has been marked as a duplicate of this bug. ***

Please review th/proxy-rh1444374

> proxy: unify logging in nm-pacrunner-manager

+               nm_log ((level), _NMLOG_DOMAIN, NULL, NULL, \
+                       "%s%p]: " _NM_UTILS_MACRO_FIRST(__VA_ARGS__), \
+                       "pacrunner: call[", \
+                       (config) \
+                       _NM_UTILS_MACRO_REST(__VA_ARGS__)); \

Why "%s%p]: " and "pacrunner: call[" are split in such way?

Pushed a typo fixup, otherwise looks good.

(In reply to Beniamino Galvani from comment #3)
> > proxy: unify logging in nm-pacrunner-manager
> 
> +               nm_log ((level), _NMLOG_DOMAIN, NULL, NULL, \
> +                       "%s%p]: " _NM_UTILS_MACRO_FIRST(__VA_ARGS__), \
> +                       "pacrunner: call[", \
> +                       (config) \
> +                       _NM_UTILS_MACRO_REST(__VA_ARGS__)); \
> 
> Why "%s%p]: " and "pacrunner: call[" are split in such way?

it saves ": call[" which would be part of every logging string otherwise. Yeah, I know, that amounts to a dozen bytes.


merged upstream.

master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=b495d0bf94e5cc043636064abf8a6053ff965af2

nm-1-8: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=424e6c853825b638d2c08b7edca58390205082c1

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:2299