Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://lbalhar.fedorapeople.org/python2-ipython.spec SRPM URL: https://lbalhar.fedorapeople.org/python2-ipython-5.3.0-5.fc25.src.rpm Description: IPython provides a replacement for the interactive Python interpreter with extra functionality Fedora Account System Username: lbalhar Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19128692 The newest version of IPython (6.0.0) dropped support for Python 2. This package is a way how to maintain IPython versions (5.x) compatible with Python 2 in Fedora. More info here: https://bugzilla.redhat.com/show_bug.cgi?id=1441004 The package contains a patch which was merged a while ago so it will be removed in next version. PR: https://github.com/ipython/ipython/pull/10476
The main package lacks ?python_provide
Fixed in original files. New Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19171637
There is no %license. Upstream has license_and_copyright.rst.txt, please include it as %license
Several issues found, see bellow: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: IPython/utils/_signatures.py is reported as Apache by licensecheck, but it is BSD, so that's fine. [!]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [-]: Package does not own files or directories owned by other packages. Note: This is a replacement for python-ipython, so this is happening so far, but intended. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [-]: Package does not generate any conflict. Note: So far it does generate file conflict, but only for python-ipython [x]: Package obeys FHS, except libexecdir and /usr/target. [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. Note: I believe provides and obsoletes for "ipython" are missing. [!]: Requires correct, justified where necessary. Note: Use python2-backports-shutil_get_terminal_size, python2-ipython, python2-jsonschema, python2-path and python2-traitlets in (Build)Requires instead of python-***; python2-pathlib and python2-mistune are not yet available, so keep python-*** here [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [*]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Not applicable [?]: Package functions as described. [?]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Note: Add link to Patch0. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-ipython-5.3.0-5.fc27.noarch.rpm python2-ipython-sphinx-5.3.0-5.fc27.noarch.rpm python2-ipython-tests-5.3.0-5.fc27.noarch.rpm python2-ipython-doc-5.3.0-5.fc27.noarch.rpm python2-ipython-5.3.0-5.fc27.src.rpm python2-ipython.noarch: W: spelling-error %description -l en_US pdb -> pd, db, pub python2-ipython.noarch: W: no-manual-page-for-binary ipython2 python2-ipython-sphinx.noarch: W: spelling-error %description -l en_US pdb -> pd, db, pub python2-ipython-sphinx.noarch: W: no-documentation python2-ipython-tests.noarch: W: no-documentation python2-ipython-tests.noarch: W: no-manual-page-for-binary iptest2 python2-ipython-tests.noarch: W: no-manual-page-for-binary iptest python2-ipython.src: W: spelling-error %description -l en_US pdb -> pd, db, pub 5 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- python2-ipython-sphinx.noarch: W: spelling-error %description -l en_US embeddable -> embedded python2-ipython-sphinx.noarch: W: spelling-error %description -l en_US pdb -> pd, db, pub python2-ipython-sphinx.noarch: W: spelling-error %description -l en_US profiler -> profile, profiles, profiled python2-ipython-sphinx.noarch: W: invalid-url URL: http://ipython.org/ <urlopen error [Errno -2] Name or service not known> python2-ipython-sphinx.noarch: W: no-documentation python2-ipython.noarch: W: spelling-error %description -l en_US embeddable -> embedded python2-ipython.noarch: W: spelling-error %description -l en_US pdb -> pd, db, pub python2-ipython.noarch: W: spelling-error %description -l en_US profiler -> profile, profiles, profiled python2-ipython.noarch: W: invalid-url URL: http://ipython.org/ <urlopen error [Errno -2] Name or service not known> python2-ipython.noarch: W: no-manual-page-for-binary ipython2 python2-ipython-doc.noarch: W: invalid-url URL: http://ipython.org/ <urlopen error [Errno -2] Name or service not known> python2-ipython-tests.noarch: W: invalid-url URL: http://ipython.org/ <urlopen error [Errno -2] Name or service not known> python2-ipython-tests.noarch: W: no-documentation python2-ipython-tests.noarch: W: no-manual-page-for-binary iptest python2-ipython-tests.noarch: W: no-manual-page-for-binary iptest2 4 packages and 0 specfiles checked; 0 errors, 15 warnings. All fine. Requires -------- python2-ipython-sphinx (rpmlib, GLIBC filtered): python(abi) python2-ipython python2-sphinx python2-ipython (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) python-backports-shutil_get_terminal_size python-ipython python-jsonschema python-mistune python-path python-pathlib python-traitlets python2-decorator python2-pickleshare python2-prompt_toolkit python2-setuptools python2-simplegeneric python2-zmq python2-ipython-doc (rpmlib, GLIBC filtered): python2-ipython-tests (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) python2-ipykernel python2-ipython python2-jupyter-client python2-nbformat python2-nose python2-pytest python2-testpath python2-zmq-tests Provides -------- python2-ipython-sphinx: python-ipython-sphinx python2-ipython-sphinx python2-ipython: ipython2 python-ipython python2-ipython python2-ipython-console python2.7dist(ipython) python2dist(ipython) python2-ipython-doc: python-ipython-doc python2-ipython-doc python2-ipython-tests: python-ipython-tests python2-ipython-tests Source checksums ---------------- https://files.pythonhosted.org/packages/source/i/ipython/ipython-5.3.0.tar.gz : CHECKSUM(SHA256) this package : bf5e615e7d96dac5a61fbf98d9e2926d98aa55582681bea7e9382992a3f43c1d CHECKSUM(SHA256) upstream package : bf5e615e7d96dac5a61fbf98d9e2926d98aa55582681bea7e9382992a3f43c1d
> [!]: License file installed when any subpackage combination is installed. File COPYING.rst from source tarball added to all subpackages. > [!]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. Based on documentation and COPYING.rst, I changed the license to BSD. > [!]: If the package is a rename of another package, proper Obsoletes and > Provides are present. > Note: I believe provides and obsoletes for "ipython" are missing. Added Obsoletes: %{pypi_name} < 5.3.0-4 Provides: %{pypi_name} = %{version}-%{release} > [!]: Requires correct, justified where necessary. > Note: Use python2-backports-shutil_get_terminal_size, python2-ipython, > python2-jsonschema, python2-path and python2-traitlets in (Build)Requires > instead of python-***; python2-pathlib and python2-mistune are not yet > available, so keep python-*** here Fixed > [!]: Avoid bundling fonts in non-fonts packages. > Note: Package contains font files Fonts removed from doc subpackage. > [!]: Package does not include license text files separate from upstream. Fixed > [!]: Patches link to upstream bugs/comments/lists or are otherwise > justified. > Note: Add link to Patch0. Added link to PR (mentioned here) to specfile.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19268420
(In reply to Lumír Balhar from comment #5) > > [!]: If the package is under multiple licenses, the licensing breakdown > > must be documented in the spec. > > Based on documentation and COPYING.rst, I changed the license to BSD. Be careful, the docs are CC BY. https://github.com/ipython/ipython/blob/master/docs/source/about/license_and_copyright.rst
(In reply to Miro Hrončok from comment #7) > (In reply to Lumír Balhar from comment #5) > > > [!]: If the package is under multiple licenses, the licensing breakdown > > > must be documented in the spec. > > > > Based on documentation and COPYING.rst, I changed the license to BSD. > > Be careful, the docs are CC BY. > > https://github.com/ipython/ipython/blob/master/docs/source/about/ > license_and_copyright.rst Fixed. I've added CC-BY license for doc subpackage. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19363039
Let me check the provides again: $ dnf repoquery --provides --releasever rawhide --disablerepo \* --enablerepo fedora python2-ipython-sphinx python-ipython-sphinx = 5.3.0-4.fc27 python2-ipython-sphinx = 5.3.0-4.fc27 $ rpm -qp --provides python2-ipython-sphinx-5.3.0-5.fc27.noarch.rpm python-ipython-sphinx = 5.3.0-5.fc27 python2-ipython-sphinx = 5.3.0-5.fc27 Good. $ dnf repoquery --provides --releasever rawhide --disablerepo \* --enablerepo fedora python2-ipython ipython = 5.3.0-4.fc27 ipython2 = 5.3.0-4.fc27 python-ipython = 5.3.0-4.fc27 python-ipython-console = 5.3.0-4.fc27 python2-ipython = 5.3.0-4.fc27 python2-ipython-console = 5.3.0-4.fc27 python2.7dist(ipython) = 5.3.0 python2dist(ipython) = 5.3.0 $ rpm -qp --provides python2-ipython-5.3.0-5.fc27.noarch.rpm ipython = 5.3.0-5.fc27 ipython2 = 5.3.0-5.fc27 python-ipython = 5.3.0-5.fc27 python2-ipython = 5.3.0-5.fc27 python2-ipython-console = 5.3.0-5.fc27 python2.7dist(ipython) = 5.3.0 python2dist(ipython) = 5.3.0 python-ipython-console missing! $ dnf repoquery --provides --releasever rawhide --disablerepo \* --enablerepo fedora python2-ipython-doc ipython-doc = 5.3.0-4.fc27 python-ipython-doc = 5.3.0-4.fc27 python2-ipython-doc = 5.3.0-4.fc27 $ rpm -qp --provides python2-ipython-doc-5.3.0-5.fc27.noarch.rpm python-ipython-doc = 5.3.0-5.fc27 python2-ipython-doc = 5.3.0-5.fc27 ipython-doc missing! $ dnf repoquery --provides --releasever rawhide --disablerepo \* --enablerepo fedora python2-ipython-tests ipython-tests = 5.3.0-4.fc27 python-ipython-tests = 5.3.0-4.fc27 python2-ipython-tests = 5.3.0-4.fc27 $ rpm -qp --provides python2-ipython-tests-5.3.0-5.fc27.noarch.rpm python-ipython-tests = 5.3.0-5.fc27 python2-ipython-tests = 5.3.0-5.fc27 Good.
From spec: > # Require $current_python_interpreter-ipython > Requires: python-ipython Why is this necessary? I don't think it is anymore, maybe a leftover when "ipython" was just a "metapackage"?
Fixed. $ rpm -qp --provides RPMS/python2-ipython-5.3.0-5.fc27.noarch.rpm ipython = 5.3.0-5.fc27 ipython2 = 5.3.0-5.fc27 python-ipython = 5.3.0-5.fc27 python-ipython-console = 5.3.0-5.fc27 python2-ipython = 5.3.0-5.fc27 python2-ipython-console = 5.3.0-5.fc27 python2.7dist(ipython) = 5.3.0 python2dist(ipython) = 5.3.0 $ rpm -qp --provides RPMS/python2-ipython-doc-5.3.0-5.fc27.noarch.rpm ipython-doc = 5.3.0-5.fc27 python-ipython-doc = 5.3.0-5.fc27 python2-ipython-doc = 5.3.0-5.fc27 Also, the requirement of python-ipython removed from specfile. Thanks a lot!
APPROVED. I'll go forward with updating ipython to 6.x.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python2-ipython