Bug 1444819 - Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers
Summary: Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ packa...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: NotReady
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2017-04-24 11:45 UTC by Simon Fels
Modified: 2022-09-30 00:45 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-09-30 00:45:30 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Simon Fels 2017-04-24 11:45:27 UTC
Spec URL: https://mm.gravedo.de/files/golang-gopkg-tylerb-graceful-v1.spec
SRPM URL: https://mm.gravedo.de/files/golang-gopkg-tylerb-graceful-v1-1-1.2.15.git4654dfb.fc25.src.rpm

Description: 

This packages the golang package gopkg.in/retry.v1 which enables graceful shutdown of http.Handler servers.

Fedora Account System Username: mrmorph

Comment 1 Neal Gompa 2017-04-24 12:02:37 UTC
Taking this review.

Comment 2 Neal Gompa 2017-04-24 12:03:25 UTC
This package looks like it has remnants of gopkg.in/retry.v1 in it, please clean up and make sure that everything is sane.

Comment 3 Simon Fels 2017-04-24 12:37:14 UTC
@Neil: Fixed those.

Comment 4 Neal Gompa 2017-04-26 15:51:16 UTC
> Summary:        Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

This is too long. Shorten it to < 75 chars wide.

> %description
> %{summary}

Add a period after %{summary}.


> Provides:      golang(%{import_path}) = %{version}-%{release}
> Provides:      golang(%{import_path_sec}) = %{version}-%{release}
> Provides:      golang(%{mimport_path}) = %{version}-%{release}
> Provides:      golang(%{gimport_path}) = %{version}-%{release}

Some of these import paths are undefined, and the install steps where these are referenced are broken because of it.

Comment 5 Simon Fels 2017-04-28 07:09:41 UTC
@Neil: Updated the .spec and .src.rpm linked above.

Comment 6 Package Review 2021-04-25 00:45:30 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 7 Package Review 2021-06-04 00:46:08 UTC
This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.

Comment 8 Didik Supriadi 2021-08-30 16:53:40 UTC
The SPEC and SRPM's urls are expired

Comment 9 Package Review 2022-08-31 00:45:17 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 10 Package Review 2022-09-30 00:45:30 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.