Bug 1444819 – Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

Bug 1444819 - Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

Summary:	Review Request: golang-gopkg-tylerb-graceful-v1 - Graceful is a Go 1.3+ packa...

Status:	NEW

Aliases:	None

Product:	Fedora
Classification:	Fedora
Component:	Package Review (Show other bugs)
Sub Component:
Version:	rawhide
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	---
Target Release:	---
Assigned To:	Neal Gompa
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2017-04-24 07:45 EDT by Simon Fels
Modified:	2017-04-28 03:09 EDT (History)
CC List:	2 users (show)

See Also:
Fixed In Version:
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Flags:	ngompa13: fedora‑review?

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Simon Fels 2017-04-24 07:45:27 EDT

Spec URL: https://mm.gravedo.de/files/golang-gopkg-tylerb-graceful-v1.spec
SRPM URL: https://mm.gravedo.de/files/golang-gopkg-tylerb-graceful-v1-1-1.2.15.git4654dfb.fc25.src.rpm

Description: 

This packages the golang package gopkg.in/retry.v1 which enables graceful shutdown of http.Handler servers.

Fedora Account System Username: mrmorph

Comment 1 Neal Gompa 2017-04-24 08:02:37 EDT

Taking this review.

Comment 2 Neal Gompa 2017-04-24 08:03:25 EDT

This package looks like it has remnants of gopkg.in/retry.v1 in it, please clean up and make sure that everything is sane.

Comment 3 Simon Fels 2017-04-24 08:37:14 EDT

@Neil: Fixed those.

Comment 4 Neal Gompa 2017-04-26 11:51:16 EDT

> Summary:        Graceful is a Go 1.3+ package enabling graceful shutdown of http.Handler servers

This is too long. Shorten it to < 75 chars wide.

> %description
> %{summary}

Add a period after %{summary}.


> Provides:      golang(%{import_path}) = %{version}-%{release}
> Provides:      golang(%{import_path_sec}) = %{version}-%{release}
> Provides:      golang(%{mimport_path}) = %{version}-%{release}
> Provides:      golang(%{gimport_path}) = %{version}-%{release}

Some of these import paths are undefined, and the install steps where these are referenced are broken because of it.

Comment 5 Simon Fels 2017-04-28 03:09:41 EDT

@Neil: Updated the .spec and .src.rpm linked above.

Note You need to log in before you can comment on or make changes to this bug.