Created attachment 1273658 [details]
Redis-Shutdown proposed change
Description of problem:
Consider the following scenario, you have redis listening only on unix socket but not on any port or interface.
The error from systemd was redis.service stopping timed out. Terminating. because it was trying to stop a redis on 127.0.0.1 and port 0 obviously, because redis was not running on port.
So i fixed the redis-shutdown wrapper, it now uses socket, if there is one, and behaves normally when there isnt one.
Proposed redis-shutdown with fix is in attachment
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. make redis listen on port 0
2. start redis
3. stop redis
systemd was redis.service stopping timed out
restart redis service
I'm not involved with this package but I noticed that it appears to be fixed in rawhide with redis-3.2.9-1, even referencing this bug specifically.
- Fix a shutdown failure with Unix domain sockets (RHBZ #1444988)
Now it's just a matter of backporting it to the epel7 branch.
If anyone needs this fix, I've produced a COPR with a
fixed version (3.2.10 currently) for el6 and el7 here:
redis-3.2.10-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-07d2039ffa
redis-3.2.10-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-07d2039ffa
redis-3.2.10-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.