Description of problem: virt-manager skip authentication only for VNC with listen type none. Version-Release number of selected component (if applicable): virt-manager-1.4.1-2.el7.noarch virt-install-1.4.1-2.el7.noarch virt-manager-common-1.4.1-2.el7.noarch qemu-kvm-rhev-2.8.0-6.el7.x86_64 libvirt-3.2.0-3.el7.x86_64 How reproducible: 100% Steps to Reproduce: 1. Prepare a vnc guest: Listen type: none # virsh dumpxml rhel7.3latest-vnc --security-info <graphics type='vnc' port='-1' autoport='yes' passwd='aabb'> <listen type='none'/> </graphics> 2. Launch virt-manager, then double click guest to connect to guest console. Result: Can login guest without authentication.(http://post-office.corp.redhat.com/archives/rhvirt-patches/2017-March/msg00817.html) Actual results: As description. Expected results: For QEMU has a Bug 1435352 and because of that we need to skip authentication for listen type=none. Once it gets fixed in QEMU we need update the code in virt-manager to skip the authentication only for broken QEMUs. Additional info:
Hi Pavel, I noticed that Bug 1435352 has been fixed, so will you do a fix in virt-manager code, thanks.
Upstream commit: commit 0e812e3c423787ac0392f9c083d20a5ca7d0ed8c Author: Pavel Hrdina <phrdina> Date: Tue Jan 16 09:30:50 2018 +0100 vnc: don't skip authentication for listen type none with fixed QEMU